From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dd14210.kasserver.com (dd14210.kasserver.com [85.13.138.83]) by sourceware.org (Postfix) with ESMTPS id 538F33858D1E for ; Wed, 13 Jul 2022 21:15:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 538F33858D1E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=milianw.de Authentication-Results: sourceware.org; spf=none smtp.mailfrom=milianw.de Received: from milian-workstation.localnet (p54a1bbed.dip0.t-ipconnect.de [84.161.187.237]) by dd14210.kasserver.com (Postfix) with ESMTPSA id 5D107240061; Wed, 13 Jul 2022 23:15:30 +0200 (CEST) From: Milian Wolff To: Mark Wielaard Cc: Aaron Merey , elfutils-devel@sourceware.org Subject: Re: [PATCH] Introduce public dwfl_get_debuginfod_client API Date: Wed, 13 Jul 2022 23:15:29 +0200 Message-ID: <1874913.LJ49KAohvX@milian-workstation> In-Reply-To: References: <3003776.hSsdSGGBHf@milian-workstation> <92098475.pnLdKSaa6h@milian-workstation> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart2263344.I4EYRGg46j"; micalg="pgp-sha256"; protocol="application/pgp-signature" X-Spamd-Bar: - X-Spam-Status: No, score=1.1 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, KAM_LAZY_DOMAIN_SECURITY, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Level: * X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: elfutils-devel@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Elfutils-devel mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Jul 2022 21:15:35 -0000 --nextPart2263344.I4EYRGg46j Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii"; protected-headers="v1" From: Milian Wolff To: Mark Wielaard Cc: Aaron Merey , elfutils-devel@sourceware.org Subject: Re: [PATCH] Introduce public dwfl_get_debuginfod_client API Date: Wed, 13 Jul 2022 23:15:29 +0200 Message-ID: <1874913.LJ49KAohvX@milian-workstation> In-Reply-To: MIME-Version: 1.0 On Mittwoch, 13. Juli 2022 22:38:51 CEST Mark Wielaard wrote: > Hi Milian, > > On Wed, Jul 13, 2022 at 09:36:45PM +0200, Milian Wolff wrote: > > On Mittwoch, 13. Juli 2022 20:20:04 CEST Aaron Merey wrote: > > > There weren't any concerns with the patch so I've gone ahead and merged > > > it as commit a4b1839c3c46. > > Yeah, sorry, I should have spoken up on the list not just mumbled > something on irc. My only concern was that I was afraid to pull in > libdebuginfod.h api by default. But you handled to by making > debuginfod_client handle an opaque pointer, which it of course is. So > my worry was unfounded. > > But I did just now see it has a typo in libdw.map: > > ELFUTILS_0.187 { > global: > dwfl_get_debuginfod_client; > } ELFUTILS_0.186; > > That should be ELFUTILS_0.188 we already released 0.187. Ah, thanks for spotting that. > Also (micro optimazition to prevent a PLT call) the internal calls > should use INTUSE (dwfl_get_debuginfod_client). TIL, thanks. I probably will never feel at home in C code bases with all these arcane macros :D > I made both changes and added a NEWS entry. See attached. LGTM. > > I got spammed by a flood of mails from buildbot, but from what I can tell > > the issues are all unrelated to my patch? Or did I break something? See > > e.g.: > > > > [1]: https://builder.sourceware.org/buildbot/#/builders/39/builds/41 > > Those are unrelated to your patch OK, thanks. -- Milian Wolff mail@milianw.de http://milianw.de --nextPart2263344.I4EYRGg46j Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. Content-Transfer-Encoding: 7Bit -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEezawi1aUvUGg3A1+8zYW/HGdOX8FAmLPNfIACgkQ8zYW/HGd OX+E7xAAj9HPKy1fHPzn6nB6HcKmRQ6uTaOsYAk7AyQCjswVCPxa53WvLv1kEoC9 ybhDLxiarJXgn0VrI3vLW36Vm/4U0qdkmhkxdAG73oY4HJqULtUYv7o3SBYDUJFu 5Ga2sJXG54fuqpbf0PbzG7EEVQ1h4WHHVG+c+obmtiwjviVWXIj0ZDpFiCElwvBC Zn0UI+dUT0dg43shfHv2p3c0Yuq2LAsVaAdiQOT7xeN/kM1ODeFXywHnC6762SF8 fO++bLCzEcGUa2mME0Sj7id1FYN91jQzyjcFgMGgwPxexD4hVamqFP2nhyiVt0Yg uXYXtBpAeRJgMc1tSrkwm5wXr9kS3CEUxOGJuKx1yHiUxmBVuG9XX7FlIZ4wseGp Hwn6rw2F8b/XyH1wCXE+7c8BlqUVDDkp/CoAUOnIp/TNZuE8fKjeI5wUKjrF4qxz vY7I0PBvm8iIV4+N6ShGP6gFkR52OgphWUP06LjOzK9RATQJQ5r6Eizpj7aMPJsh 9USdg8j5FjcRXAs9UzyZ01jwaCJhSPQwFA38LeiuMCl9boBtm0ARBrEFQOpiXZTz 7gjT/VIa/NfUe0AJa1CtH2jpvFFgEN4IZw0uau1fOL/l0yFP8yTBW/i7eLuRFL0s A0kt13xInnuwOjCg/8jQRjUvEcKYuJK1NRI7Pl9fQysiGTvjrdQ= =z6Uo -----END PGP SIGNATURE----- --nextPart2263344.I4EYRGg46j--