From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gnu.wildebeest.org (gnu.wildebeest.org [45.83.234.184]) by sourceware.org (Postfix) with ESMTPS id 650F73858D33 for ; Thu, 16 Feb 2023 13:08:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 650F73858D33 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=klomp.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=klomp.org Received: from r6.localdomain (82-217-174-174.cable.dynamic.v4.ziggo.nl [82.217.174.174]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id 9344830067D7; Thu, 16 Feb 2023 14:08:03 +0100 (CET) Received: by r6.localdomain (Postfix, from userid 1000) id 20ECB3401E3; Thu, 16 Feb 2023 14:08:03 +0100 (CET) Message-ID: <188c194df1b722440dd6f8757390b26a42a94cfa.camel@klomp.org> Subject: Re: [PATCH] configure: Error when demangler is enabled, but libstdc++ support isn't From: Mark Wielaard To: Florian Weimer Cc: elfutils-devel@sourceware.org Date: Thu, 16 Feb 2023 14:08:03 +0100 In-Reply-To: <87o7ptrimz.fsf@oldenburg.str.redhat.com> References: <20230215160030.45630-1-mark@klomp.org> <87o7ptrimz.fsf@oldenburg.str.redhat.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.3 (3.46.3-1.fc37) MIME-Version: 1.0 X-Spam-Status: No, score=-3036.1 required=5.0 tests=BAYES_00,GIT_PATCH_0,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,RCVD_IN_BARRACUDACENTRAL,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Florian, On Thu, 2023-02-16 at 11:48 +0100, Florian Weimer via Elfutils-devel wrote: > * Mark Wielaard: >=20 > > + [AC_MSG_ERROR([__cxa_demangle not found in libstdc++ use --disab= le-demangler to disable demangler support.])]), >=20 > Missing punctuation after libstdc++? You probably mean you like to see a comma after libstdc++? That sounds reasonable. But I had to double quote the argument to AC_MSG_ERROR, otherwise the comma was seen as a argument separator? Which I find slightly odd, but I don't fully grok autoconf quotes. Does the following do what you expect? diff --git a/configure.ac b/configure.ac index 1ef45c0f..4c8a4c31 100644 --- a/configure.ac +++ b/configure.ac @@ -499,7 +499,7 @@ AC_DEFINE([USE_DEMANGLE], [1], [Defined if demangling i= s enabled])]) AM_CONDITIONAL(DEMANGLE, test "x$ac_cv_lib_stdcpp___cxa_demangle" =3D "xye= s") AS_IF([test "x$ac_cv_lib_stdcpp___cxa_demangle" =3D "xyes"], [enable_demangler=3Dyes], - [AC_MSG_ERROR([__cxa_demangle not found in libstdc++ use --disable-d= emangler to disable demangler support.])]), + [AC_MSG_ERROR([[__cxa_demangle not found in libstdc++, use --disable= -demangler to disable demangler support.]])]), AM_CONDITIONAL(DEMANGLE, false)) =20 AC_ARG_ENABLE([textrelcheck], Thanks, Mark