From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=U2dh=6F=klomp.org=mark@sourceware.org>
Received: from gnu.wildebeest.org (gnu.wildebeest.org [45.83.234.184])
	by sourceware.org (Postfix) with ESMTPS id A028D3881D3A
	for <elfutils-devel@sourceware.org>; Thu,  9 Feb 2023 13:28:45 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A028D3881D3A
Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=klomp.org
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=klomp.org
Received: from r6.localdomain (82-217-174-174.cable.dynamic.v4.ziggo.nl [82.217.174.174])
	(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by gnu.wildebeest.org (Postfix) with ESMTPSA id 9E61A30067CA;
	Thu,  9 Feb 2023 14:28:43 +0100 (CET)
Received: by r6.localdomain (Postfix, from userid 1000)
	id 677AE3401CE; Thu,  9 Feb 2023 14:28:43 +0100 (CET)
Message-ID: <189731e7bb06d164b784360d36a6cf3b557af551.camel@klomp.org>
Subject: Re: [PATCH v2 5/7] configure: Use -fno-addrsig if possible
From: Mark Wielaard <mark@klomp.org>
To: Ilya Leoshkevich <iii@linux.ibm.com>
Cc: elfutils-devel@sourceware.org
Date: Thu, 09 Feb 2023 14:28:43 +0100
In-Reply-To: <20230208195226.144143-6-iii@linux.ibm.com>
References: <20230208195226.144143-1-iii@linux.ibm.com>
	 <20230208195226.144143-6-iii@linux.ibm.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.46.3 (3.46.3-1.fc37) 
MIME-Version: 1.0
X-Spam-Status: No, score=-3036.3 required=5.0 tests=BAYES_00,GIT_PATCH_0,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,KAM_SHORT,RCVD_IN_BARRACUDACENTRAL,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <elfutils-devel.sourceware.org>

Hi Ilya,

On Wed, 2023-02-08 at 20:52 +0100, Ilya Leoshkevich wrote:
> By default, clang produces .llvm_addrsig sections [1]. The GNU
> toolchain does not know how to handle them yet [2], so just ask clang
> not to generate them for the time being.
>=20
> [1] https://llvm.org/docs/Extensions.html#sht-llvm-addrsig-section-addres=
s-significance-table
> [2] https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D105625

That looks like a good generic configure check.
Pushed.

Thanks,

Mark

> Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com>
> ---
>  configure.ac | 8 ++++++++
>  1 file changed, 8 insertions(+)
>=20
> diff --git a/configure.ac b/configure.ac
> index 8fe8baee..7dc9be63 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -588,6 +588,14 @@ CFLAGS=3D"$old_CFLAGS"])
>  AM_CONDITIONAL(HAVE_NO_PACKED_NOT_ALIGNED_WARNING,
>  	       [test "x$ac_cv_no_packed_not_aligned" !=3D "xno"])
> =20
> +AC_CACHE_CHECK([whether the compiler accepts -fno-addrsig], ac_cv_fno_ad=
drsig, [dnl
> +old_CFLAGS=3D"$CFLAGS"
> +CFLAGS=3D"$CFLAGS -fno-addrsig -Werror"
> +AC_COMPILE_IFELSE([AC_LANG_SOURCE([])],
> +                  ac_cv_fno_addrsig=3Dyes, ac_cv_fno_addrsig=3Dno)
> +CFLAGS=3D"$old_CFLAGS"])
> +AS_IF([test "x$ac_cv_fno_addrsig" =3D "xyes"], CFLAGS=3D"$CFLAGS -fno-ad=
drsig")
> +
>  saved_LIBS=3D"$LIBS"
>  AC_SEARCH_LIBS([argp_parse], [argp])
>  LIBS=3D"$saved_LIBS"