From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from va-1-13.ptr.blmpb.com (va-1-13.ptr.blmpb.com [209.127.230.13]) by sourceware.org (Postfix) with ESMTPS id 114973858D20 for ; Fri, 29 Mar 2024 07:40:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 114973858D20 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=oss.cipunited.com Authentication-Results: sourceware.org; spf=none smtp.mailfrom=oss.cipunited.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 114973858D20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=209.127.230.13 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711698022; cv=none; b=q7aUVXjtJHJfrgpQwRtuM3sQlshhmiXlS2V17/oiMPeE1JMXEmTLBFQV7K18jphlybNlByh/+HQeHjh3/YI68T+wtfkOCYmjMs+6+Z9wiZEP21AisFcChzBZ0fXXR+6uAkd5wWLex/dlh2MEGZlSm1Rq9K53o5H+rKLjQs7A+eU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711698022; c=relaxed/simple; bh=SdIaQxKFqcrQdOMyWyAEc6QitDygjNa2/eQlldSgJJU=; h=DKIM-Signature:From:Message-Id:Mime-Version:To:Subject:Date; b=BPdCSaXFtstgSG0BgzQSbey2SMnWRbz/150jZQqBkIPFjAYWkwtK+8ob48VvxYYmpUjbOKr0o1XCPkZ0kHXdL97bn1xXkewTbnFF1YfUi9WVf3H3A1tznfpvIj86vFGj4OnqXvnIPmahCu4c9CMVsKX43T2TzLo9ounEmvH3JBY= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; s=feishu2303200042; d=oss.cipunited.com; t=1711698014; h=from:subject:mime-version:from:date:message-id:subject:to:cc: reply-to:content-type:mime-version:in-reply-to:message-id; bh=HGrAM9AQou9Mr/qhgzu/gVOz+/o+FDmP+THxRF+orQ0=; b=yi1GPFI9a27e/kCbOLnXaey7VB0SMjnh8LplxeIKZ1j9lE9nCl361IUqtj3/78XkmcPnwK +wd9N7SfNAtCHRkHOG92RrHUfxwankB0W0jCEar5P6vcUD7h2bCexz/zcEPQYEPmnzSFfP PIvyNRDdiHsVyPYdYsn5Sg25GlmIHRL3Fe91WKkh6craviiD4/ggchy2tr7klNQKgdr08j fqn+J3nngtQdfZIVyymC53aR65U8tACRwI4nEGDuMdX3aCoWShQCh6wcbzPh718DjFCl44 Yb+U8kP11ec6WLJOmXX5DC7nrrMuOD1r0v9ugH4sTGQctNHWJFZ8+My8JZZieA== Cc: Content-Language: en-US Received: from [192.168.8.150] ([123.52.19.173]) by smtp.feishu.cn with ESMTPS; Fri, 29 Mar 2024 15:40:12 +0800 In-Reply-To: <20240329001807.GR9427@gnu.wildebeest.org> User-Agent: Mozilla Thunderbird X-Lms-Return-Path: From: "Ying Huang" Message-Id: <1c09b621-201c-4a9b-8bff-e83f04ad51f6@oss.cipunited.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 To: "Mark Wielaard" Subject: Re: [PATCH v3 1/6] Support Mips architecture Date: Fri, 29 Mar 2024 15:40:11 +0800 Content-Transfer-Encoding: quoted-printable References: <20240305095122.889077-2-ying.huang@oss.cipunited.com> <20240329001807.GR9427@gnu.wildebeest.org> X-Original-From: Ying Huang X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00,DKIM_INVALID,DKIM_SIGNED,KAM_DMARC_STATUS,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Mark, Next time I send a patch, I will add ChangeLog entry in commit message and = check the added file. Thanks, Ying =E5=9C=A8 2024/3/29 08:18, Mark Wielaard =E5=86=99=E9=81=93: > Hi Ying, > > On Tue, Mar 05, 2024 at 05:51:17PM +0800, Ying Huang wrote: >> From: Ying Huang >> >> Signed-off-by: Ying Huang >> --- >> backends/Makefile.am | 6 +- >> backends/mips_init.c | 52 ++++ >> backends/mips_reloc.def | 93 +++++++ >> backends/mips_symbol.c | 63 +++++ >> libebl/eblopenbackend.c | 2 + >> libelf/libelfP.h | 3 + >> tests/libelf.h | 541 ++++++++++++++++++++++++++++++++++++++++ > Note that this adds tests/libelf.h by accident. I see how that could > happen, because it should have been in .gitignore. I posted a patch > to do that: > https://inbox.sourceware.org/elfutils-devel/20240328234308.1032110-1-mark= @klomp.org/ > > Besides that the patch looks fine. I did add a ChangeLog entry to the > commit message. Pushed as attached. > > Thanks, > > Mark