From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15387 invoked by alias); 5 Dec 2018 12:13:35 -0000 Mailing-List: contact elfutils-devel-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Post: List-Help: List-Subscribe: Sender: elfutils-devel-owner@sourceware.org Received: (qmail 15368 invoked by uid 89); 5 Dec 2018 12:13:34 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.100.2 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_PASS autolearn=ham version=3.3.2 spammy= X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_PASS autolearn=ham version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on sourceware.org X-Spam-Level: X-HELO: gnu.wildebeest.org Received: from wildebeest.demon.nl (HELO gnu.wildebeest.org) (212.238.236.112) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 05 Dec 2018 12:13:32 +0000 Received: from tarox.wildebeest.org (tarox.wildebeest.org [172.31.17.39]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id 7D9FC302BBFE; Wed, 5 Dec 2018 13:13:30 +0100 (CET) Received: by tarox.wildebeest.org (Postfix, from userid 1000) id 31632400114F; Wed, 5 Dec 2018 13:13:30 +0100 (CET) Message-ID: <1da77251eec33ae5a8be6b7e58988a4bdf8012c8.camel@klomp.org> Subject: Re: [PATCH] libebl: Fix reading GNU_PROPERTY_STACK_SIZE reading from 32bit notes. From: Mark Wielaard To: elfutils-devel@sourceware.org Cc: mcermak@redhat.com Date: Wed, 05 Dec 2018 12:13:00 -0000 In-Reply-To: <20181202231546.33197-1-mark@klomp.org> References: <20181202231546.33197-1-mark@klomp.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Evolution 3.28.5 (3.28.5-2.el7) Mime-Version: 1.0 X-Spam-Flag: NO X-IsSubscribed: yes X-SW-Source: 2018-q4/txt/msg00216.txt.bz2 On Mon, 2018-12-03 at 00:15 +0100, Mark Wielaard wrote: > When reading a GNU_PROPERTY_STACK_SIZE we need to use the proper data > type. GElf_Addr is 64bit always and when reading a 32bit size part of > it would not be initialized. Use either Elf32_Addr or Elf64_Addr to > read and print the data. >=20 > Add 32bit and 64bit, little and big endian testcases. Pushed to master.