Re: [PATCH] aarch64: use <sys/user.h> defined register structures

[Kyle McMartin <kmcmarti@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1475 bytes --]

On Tue, Jun 10, 2014 at 11:51:48AM +0200, Mark Wielaard wrote:
> On Mon, 2014-06-09 at 21:06 +0200, Kyle McMartin wrote:
> > glibc now supplies these (compatible) structs instead of including the
> > kernel's <asm/ptrace.h> header, so let's use them. Annoyingly this will
> > cause new elfutils to FTBFS on old glibc, and vice versa, but that seems
> > unavoidable in the growth of a new port, and the workaround of checking
> > for header defines and defining one to the other seems unpleasant as
> > well. Therefore, bite the bullet, and let packaging systems alter their
> > build requires accordingly.
> 
> That is indeed annoying, but using the glibc defined structs seems to be
> the right thing to do. Do you know which glibc version introduced them?
> 

Hrm, looks like it's rawhide churn which has caused this... I guess
it'll be in glibc 2.20, but isn't in a released version. I can sit on
this and resend this patch when it is, if you'd like?

> BTW. For this trivial patch it doesn't really matter, but in general we
> like to have a Signed-off-by line for all patches to indicate
> contributors know about and agree with our CONTRIBUTING guidelines.
> Would you mind adding one?
> https://git.fedorahosted.org/cgit/elfutils.git/tree/CONTRIBUTING
> 

Sure, I'll add this to the v2 for the next glibc release? Otherwise
adding
Signed-off-by: Kyle McMartin <kyle@redhat.com>
is fine by me.

regards, Kyle

> Thanks,
> 
> Mark
>