From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============7707709911821714843==" MIME-Version: 1.0 From: Kyle McMartin To: elfutils-devel@lists.fedorahosted.org Subject: Re: [PATCH] aarch64: use defined register structures Date: Tue, 10 Jun 2014 09:37:39 -0400 Message-ID: <20140610133739.GD29969@redacted.bos.redhat.com> In-Reply-To: 1402393908.3940.41.camel@bordewijk.wildebeest.org --===============7707709911821714843== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable On Tue, Jun 10, 2014 at 11:51:48AM +0200, Mark Wielaard wrote: > On Mon, 2014-06-09 at 21:06 +0200, Kyle McMartin wrote: > > glibc now supplies these (compatible) structs instead of including the > > kernel's header, so let's use them. Annoyingly this will > > cause new elfutils to FTBFS on old glibc, and vice versa, but that seems > > unavoidable in the growth of a new port, and the workaround of checking > > for header defines and defining one to the other seems unpleasant as > > well. Therefore, bite the bullet, and let packaging systems alter their > > build requires accordingly. > = > That is indeed annoying, but using the glibc defined structs seems to be > the right thing to do. Do you know which glibc version introduced them? > = Hrm, looks like it's rawhide churn which has caused this... I guess it'll be in glibc 2.20, but isn't in a released version. I can sit on this and resend this patch when it is, if you'd like? > BTW. For this trivial patch it doesn't really matter, but in general we > like to have a Signed-off-by line for all patches to indicate > contributors know about and agree with our CONTRIBUTING guidelines. > Would you mind adding one? > https://git.fedorahosted.org/cgit/elfutils.git/tree/CONTRIBUTING > = Sure, I'll add this to the v2 for the next glibc release? Otherwise adding Signed-off-by: Kyle McMartin is fine by me. regards, Kyle > Thanks, > = > Mark >=20 --===============7707709911821714843==--