From mboxrd@z Thu Jan  1 00:00:00 1970
Content-Type: multipart/mixed; boundary="===============4770803727152892710=="
MIME-Version: 1.0
From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: elfutils-devel@lists.fedorahosted.org
Subject: Re: [PATCH] libdwfl: Record dwfl_attach_state error and return it on
 failure.
Date: Wed, 11 Jun 2014 22:26:38 +0200
Message-ID: <20140611202638.GA22213@host2.jankratochvil.net>
In-Reply-To: 1402493608-8929-1-git-send-email-mjw@redhat.com

--===============4770803727152892710==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable

On Wed, 11 Jun 2014 15:33:28 +0200, Mark Wielaard wrote:
> When dwfl_attach_state fails functions that need the process state should
> return the error that caused the attach to fail. Use this in the backtrace
> test to signal any attach failure. This makes sure that architectures that
> don't provide unwinder support get properly detected (and the tests SKIPs)
> Also don't assert when trying to attach a non-core ELF file, but return an
> error to indicate failure.

This patch reimplements former 'process_attach_error' under the new name
'attacherr'.  It is also related to the current requirement to call
dwfl_linux_proc_attach() explicitly by the clients since:
	commit 19108019192ab273c53ae324be448d29dac806ca
	Author: Mark Wielaard <mjw@redhat.com>
	Date:   Mon Dec 30 22:00:57 2013 +0100
	    libdwfl: Add dwfl_core_file_attach and dwfl_linux_proc_attach.
So I rather do not agree with the former patch which this one fixes.


Jan

--===============4770803727152892710==--