public inbox for elfutils@sourceware.org
 help / color / mirror / Atom feed
From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: elfutils-devel@lists.fedorahosted.org
Subject: [patch] Fix report_r_debug for prelinked libraries
Date: Thu, 24 Jul 2014 20:50:28 +0200	[thread overview]
Message-ID: <20140724185028.GA13828@host2.jankratochvil.net> (raw)

[-- Attachment #1: Type: text/plain, Size: 1054 bytes --]

Hi,

jankratochvil/l_addr

eu-stack: "Callback returned failure" for seemingly OK shared libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1112610#c2

attaching the fix.  I find it obviously right.
It also has no testsuite regressions.

The problem was that user dumping the core file had DSOs prelinked but
downloaded DSOs from RPMs are not prelinked.  l_addr is then zero but it
cannot be determined from the DSO file.

Unfortunately I do not provide a testcase.  It fixes the Bug above as tested
on its core file but I cannot disclose the core file (or its parts).
And despite I did try I haven't reproduced it by a hand-made testcase.

The problem is the modules placing code got overcomplicated and IMO it could
be simplified one day.  There is the former placement which works somehow and
there is the placement by patches of mine which force it here and there to the
right positions.  Trying to exploit failure of the add-on code of mine always
ended up on the former code placing it right on its own.


Thanks,
Jan

[-- Attachment #2: attachment.mht --]
[-- Type: message/rfc822, Size: 47 bytes --]


WzxlbWFpbC5tZXNzYWdlLk1lc3NhZ2UgaW5zdGFuY2UgYXQgMHgxNTRhMmQ4Pl0=

             reply	other threads:[~2014-07-24 18:50 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-24 18:50 Jan Kratochvil [this message]
2014-07-27 20:53 Mark Wielaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140724185028.GA13828@host2.jankratochvil.net \
    --to=jan.kratochvil@redhat.com \
    --cc=elfutils-devel@lists.fedorahosted.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).