public inbox for elfutils@sourceware.org
 help / color / mirror / Atom feed
* Re: [PATCH] libdwfl: Handle LZMA .ko.xz compressed kernel modules.
@ 2014-08-15 18:16 Roland McGrath
  0 siblings, 0 replies; 3+ messages in thread
From: Roland McGrath @ 2014-08-15 18:16 UTC (permalink / raw)
  To: elfutils-devel

[-- Attachment #1: Type: text/plain, Size: 18 bytes --]

Typo in the log.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] libdwfl: Handle LZMA .ko.xz compressed kernel modules.
@ 2014-08-16 10:53 Mark Wielaard
  0 siblings, 0 replies; 3+ messages in thread
From: Mark Wielaard @ 2014-08-16 10:53 UTC (permalink / raw)
  To: elfutils-devel

[-- Attachment #1: Type: text/plain, Size: 387 bytes --]

On Fri, Aug 15, 2014 at 11:16:00AM -0700, Roland McGrath wrote:
> Typo in the log.

Found it and fixed.
And the #ifdef should have been an #if so that USE_LZMA works the same
as USE_ZLIB and USE_BZLIB when it is zero. So many typos in one tiny
patch. At least I did test it on fedora rawhide which uses xz compressed
kernel modues now.

Pushed the attached.

Cheers,

Mark

[-- Attachment #2: 0001-libdwfl-Handle-LZMA-.ko.xz-compressed-kernel-modules.patch --]
[-- Type: text/plain, Size: 1191 bytes --]

>From 9d29ed2989b6691457bbd602de740c4423ac8781 Mon Sep 17 00:00:00 2001
From: Mark Wielaard <mjw@redhat.com>
Date: Thu, 14 Aug 2014 22:07:44 +0200
Subject: [PATCH] libdwfl: Handle LZMA .ko.xz compressed kernel modules.

Linux kernel modules can not just be compressed with gz and bz2, but also
with xz.

Signed-off-by: Mark Wielaard <mjw@redhat.com>
---
 libdwfl/ChangeLog              | 4 ++++
 libdwfl/linux-kernel-modules.c | 3 +++
 2 files changed, 7 insertions(+)

diff --git a/libdwfl/ChangeLog b/libdwfl/ChangeLog
index ab47c40..c644ffe 100644
--- a/libdwfl/ChangeLog
+++ b/libdwfl/ChangeLog
@@ -1,3 +1,7 @@
+2014-08-14  Mark Wielaard  <mjw@redhat.com>
+
+	* linux-kernel-modules.c (check-suffix): Also TRY .ko.xz.
+
 2014-07-24  Jan Kratochvil  <jan.kratochvil@redhat.com>
 
 	Fix report_r_debug for prelinked libraries.
diff --git a/libdwfl/linux-kernel-modules.c b/libdwfl/linux-kernel-modules.c
index 1ad7d2f..e4065d8 100644
--- a/libdwfl/linux-kernel-modules.c
+++ b/libdwfl/linux-kernel-modules.c
@@ -302,6 +302,9 @@ check_suffix (const FTSENT *f, size_t namelen)
 #if USE_BZLIB
   TRY (".ko.bz2");
 #endif
+#if USE_LZMA
+  TRY (".ko.xz");
+#endif
 
   return 0;
 
-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH] libdwfl: Handle LZMA .ko.xz compressed kernel modules.
@ 2014-08-14 20:20 Mark Wielaard
  0 siblings, 0 replies; 3+ messages in thread
From: Mark Wielaard @ 2014-08-14 20:20 UTC (permalink / raw)
  To: elfutils-devel

[-- Attachment #1: Type: text/plain, Size: 1012 bytes --]

Linux kernel modules can not just be compressed with gz and bz2, but also
with xz.

Signed-off-by: Mark Wielaard <mjw@redhat.com>
---
 libdwfl/ChangeLog              | 4 ++++
 libdwfl/linux-kernel-modules.c | 3 +++
 2 files changed, 7 insertions(+)

diff --git a/libdwfl/ChangeLog b/libdwfl/ChangeLog
index ab47c40..e792998 100644
--- a/libdwfl/ChangeLog
+++ b/libdwfl/ChangeLog
@@ -1,3 +1,7 @@
+2014-08-14  Mark Wielaard  <mjw@redhat.com>
+
+	* linux-kernel-modules.c (check-suffix): Also TRY .ko.yz.
+
 2014-07-24  Jan Kratochvil  <jan.kratochvil@redhat.com>
 
 	Fix report_r_debug for prelinked libraries.
diff --git a/libdwfl/linux-kernel-modules.c b/libdwfl/linux-kernel-modules.c
index 1ad7d2f..61b06b6 100644
--- a/libdwfl/linux-kernel-modules.c
+++ b/libdwfl/linux-kernel-modules.c
@@ -302,6 +302,9 @@ check_suffix (const FTSENT *f, size_t namelen)
 #if USE_BZLIB
   TRY (".ko.bz2");
 #endif
+#ifdef USE_LZMA
+  TRY (".ko.xz");
+#endif
 
   return 0;
 
-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2014-08-16 10:53 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-08-15 18:16 [PATCH] libdwfl: Handle LZMA .ko.xz compressed kernel modules Roland McGrath
  -- strict thread matches above, loose matches on Subject: below --
2014-08-16 10:53 Mark Wielaard
2014-08-14 20:20 Mark Wielaard

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).