From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============4710975007934199433==" MIME-Version: 1.0 From: Jan Kratochvil To: elfutils-devel@lists.fedorahosted.org Subject: Re: [PATCH 1/2] Add is_executable to Dwfl_Module. Date: Wed, 10 Sep 2014 09:21:27 +0200 Message-ID: <20140910072127.GA1967@host2.jankratochvil.net> In-Reply-To: 20140909215534.88CD12C39D8@topped-with-meat.com --===============4710975007934199433== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable On Tue, 09 Sep 2014 23:55:34 +0200, Roland McGrath wrote: > > int segment; /* Index of first segment table entry. */ > > bool gc; /* Mark/sweep flag. */ > > + bool is_executable : 1; /* Use Dwfl::executable_for_core? */ > = > If you're going to use a bitfield, then make every other bool in that > struct a bitfield too. But it's not usually worthwhile. It's > premature microoptimization that privileges memory over CPU, which > might not even be the right tradeoff any more. I really do not mind, up to the maintainer how it all should be. Jan --===============4710975007934199433==--