Re: dwarf_aggregate_size() seems to fall over on pointer types

[Mark Wielaard <mjw@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1080 bytes --]

On Thu, Oct 02, 2014 at 08:50:20AM -0400, Conrad Rad wrote:
> If you're going to tag me for Tested-by, it's "Conrad Meyer." (Google
> just doesn't let me use my real name for email and a pseudonym for all
> their other services, so it's a compromise.)

Changed.

> Looks good to me, thanks Mark. Maybe document the architecture the
> object files were produced on / the tests are in reference to? The
> sizes seem hardcoded for 64-bit pointer / 64-bit long architectures.

Yes, added that to the testcase documentation.

> I don't know the proper way to run elfutils tests, but I gave it a go:
> 
> $ export srcdir=`pwd`; ./run-aggregate-size.sh
> rmdir: failed to remove ‘test-20508’: Directory not empty
> $ echo $?
> 1
> $ ls test-20508
> testfile-sizes1.o
> 
> 
> No other output. I'm probably doing it wrong, but I didn't find any
> documentation in the tests/ directory.

The easiest way to run one test is:
make check TESTS=run-aggregate-size.sh

Pushed the fix with one addition. Added the new testfiles to EXTRA_DIST.

Thanks,

Mark