From mboxrd@z Thu Jan  1 00:00:00 1970
Content-Type: multipart/mixed; boundary="===============6055656900868363949=="
MIME-Version: 1.0
From: Mark Wielaard <mjw@redhat.com>
To: elfutils-devel@lists.fedorahosted.org
Subject: Re: dwarf_aggregate_size() seems to fall over on pointer types
Date: Thu, 02 Oct 2014 22:56:28 +0200
Message-ID: <20141002205628.GA1486@blokker.redhat.com>
In-Reply-To: CAG6CVpWRMOTLPvGf7qfLEZnhKWXs1iKM9x8EvJLGBGFri=4uzw@mail.gmail.com

--===============6055656900868363949==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable

On Thu, Oct 02, 2014 at 08:50:20AM -0400, Conrad Rad wrote:
> If you're going to tag me for Tested-by, it's "Conrad Meyer." (Google
> just doesn't let me use my real name for email and a pseudonym for all
> their other services, so it's a compromise.)

Changed.

> Looks good to me, thanks Mark. Maybe document the architecture the
> object files were produced on / the tests are in reference to? The
> sizes seem hardcoded for 64-bit pointer / 64-bit long architectures.

Yes, added that to the testcase documentation.

> I don't know the proper way to run elfutils tests, but I gave it a go:
> =

> $ export srcdir=3D`pwd`; ./run-aggregate-size.sh
> rmdir: failed to remove =E2=80=98test-20508=E2=80=99: Directory not empty
> $ echo $?
> 1
> $ ls test-20508
> testfile-sizes1.o
> =

> =

> No other output. I'm probably doing it wrong, but I didn't find any
> documentation in the tests/ directory.

The easiest way to run one test is:
make check TESTS=3Drun-aggregate-size.sh

Pushed the fix with one addition. Added the new testfiles to EXTRA_DIST.

Thanks,

Mark

--===============6055656900868363949==--