Re: Really make -Werror conditional to BUILD_WERROR

Re: Really make -Werror conditional to BUILD_WERROR

[Mike Frysinger]

[-- Attachment #1: Type: text/plain, Size: 696 bytes --]

On 10 Nov 2014 16:52, Vicente Olivert Riera wrote:
> Although you use the --disable-werror option when configuring elfutils,
> some -Werror options still being dropped in some Makefiles. We are
> applying a patch in Buildroot to fix that problem:
> 
> http://patchwork.ozlabs.org/patch/409002/
> 
> Could that patch be applied upstream?

the werror logic is in a sep branch ("portable").  if you could rebase it on top 
of that latest one and send it to the list (`git send-email`), the likelyhood of 
it getting merged would go up significantly ;).

(i know i've complained many times about merging the --disable-werror flag 
support into master, but i'll do it again ...)
-mike

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: Really make -Werror conditional to BUILD_WERROR

[Mark Wielaard]

[-- Attachment #1: Type: text/plain, Size: 682 bytes --]

On Mon, 2014-11-10 at 16:52 +0000, Vicente Olivert Riera wrote:
> Although you use the --disable-werror option when configuring elfutils,
> some -Werror options still being dropped in some Makefiles. We are
> applying a patch in Buildroot to fix that problem:
> 
> http://patchwork.ozlabs.org/patch/409002/
> 
> Could that patch be applied upstream?

If you want patches to be considered to be included upstream please post
them on this list following the guidelines in:
https://git.fedorahosted.org/cgit/elfutils.git/tree/CONTRIBUTING

I do prefer to figure out where the compile error comes from (and fix
it) instead of just squashing it though.

Thanks,

Mark

Really make -Werror conditional to BUILD_WERROR

[Vicente Olivert Riera]

[-- Attachment #1: Type: text/plain, Size: 444 bytes --]

Although you use the --disable-werror option when configuring elfutils,
some -Werror options still being dropped in some Makefiles. We are
applying a patch in Buildroot to fix that problem:

http://patchwork.ozlabs.org/patch/409002/

Could that patch be applied upstream?

Best regards,
-- 
Vicente Olivert Riera
Graduate Software Engineer, MIPS Processor IP
Imagination Technologies Limited
t: +44 (0)113 2429814
www.imgtec.com