Re: Getting rid of portable branch (Was: [PATCH 3/6] Fall back on utimes if futimes is not available)

[Mark Wielaard <mjw@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 2194 bytes --]

Hi Mike,

On Wed, May 13, 2015 at 12:09:50PM -0400, Mike Frysinger wrote:
> On 13 May 2015 16:18, Mark Wielaard wrote:
> > On Thu, 2015-05-07 at 22:08 -0400, Mike Frysinger wrote:
> > > > If there are specific hacks you would like to see brought over from the
> > > > portable branch to master, please do propose and we can discuss them.
> > > > But I really think none of them are needed or should be used these days.
> > > 
> > > there's still the issue of --disable-werror
> > 
> > I believe we discussed before, but could you remind me why it is
> > necessary for newer GCC versions?
> > 
> > If there are any warnings that are turned into errors we should really
> > just fix them. Do you have any specific examples?
> > 
> > What does the configure option add over just using CFLAGS=-Wno-error?
> 
> because you guys (reasonably) cannot test every gcc/C library
> version/flags/arch combination.  focusing on newer versions makes sense,
> but not all distros are always running the latest.  i also agree that
> having it default to on is ok and some distros which have tight control
> over everything (like fedora) will set it to on.  but i think that should
> be left to the distro to control.  in practice, we already are either by
> `sed` or patching in the werror configure flag.

Sure, but if you are using none supported versions of gcc and glibc you
are on your own already and will have to patch yourself. For the rest we
would really be error free. I do hope to setup a buildbot soon with slaves
for most supported arches to catch any issues early.

What is the advantage of --disable-werror over using CFLAGS=-Wno-error?

> keep in mind that not all warnings are even correct -- gcc has false
> positives from time to time.  trying to track how to squelch those across
> multiple gcc versions is a waste of time.

I don't think so (for a reasonable number of gcc versions). We pick the
enabled warning flags carefully and make sure no warnings slip through
(possible disabling them per file if necessary). If we enable specific
warnings in elfutils they have often caught important bugs that really
should be fixed.

Cheers,

Mark