Re: [PATCH] elfcmp: Fix leaking Ebl handles.

Re: [PATCH] elfcmp: Fix leaking Ebl handles.

[Mark Wielaard]

[-- Attachment #1: Type: text/plain, Size: 197 bytes --]

On Tue, Dec 01, 2015 at 03:08:54PM +0100, Mark Wielaard wrote:
> open_file () explicitly gets Ebl handles for both Elf files to compare.
> Make sure to close those when done.

Pushed to master.

[PATCH] elfcmp: Fix leaking Ebl handles.

[Mark Wielaard]

[-- Attachment #1: Type: text/plain, Size: 925 bytes --]

open_file () explicitly gets Ebl handles for both Elf files to compare.
Make sure to close those when done.

Signed-off-by: Mark Wielaard <mjw@redhat.com>
---
 src/ChangeLog | 4 ++++
 src/elfcmp.c  | 2 ++
 2 files changed, 6 insertions(+)

diff --git a/src/ChangeLog b/src/ChangeLog
index d6d2936..27c638f 100644
--- a/src/ChangeLog
+++ b/src/ChangeLog
@@ -1,3 +1,7 @@
+2015-12-01  Mark Wielaard  <mjw@redhat.com>
+
+	* elfcmp.c (main): Close ebl1 and ebl2 backends.
+
 2015-10-16  Mark Wielaard  <mjw@redhat.com>
 
 	* Makefile.am [BUILD_STATIC](libdw): Add -lz.
diff --git a/src/elfcmp.c b/src/elfcmp.c
index 0250fbe..852b92f 100644
--- a/src/elfcmp.c
+++ b/src/elfcmp.c
@@ -655,6 +655,8 @@ cannot read note section [%zu] '%s' in '%s': %s"),
  out:
   elf_end (elf1);
   elf_end (elf2);
+  ebl_closebackend (ebl1);
+  ebl_closebackend (ebl2);
   close (fd1);
   close (fd2);
 
-- 
2.5.0