From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18280 invoked by alias); 25 Apr 2017 22:44:18 -0000 Mailing-List: contact elfutils-devel-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Post: List-Help: List-Subscribe: Sender: elfutils-devel-owner@sourceware.org Received: (qmail 18252 invoked by uid 89); 25 Apr 2017 22:44:18 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.99.2 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY autolearn=no version=3.3.2 spammy= X-Spam-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY autolearn=no version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on sourceware.org X-Spam-Level: X-HELO: gnu.wildebeest.org Date: Wed, 26 Apr 2017 15:14:00 -0000 From: Mark Wielaard To: Ulf Hermann Cc: elfutils-devel@sourceware.org Subject: Re: [PATCH] Avoid YESSTR and NOSTR Message-ID: <20170425224407.GE13335@stream> References: <8c47d452-ec30-4fa1-a131-caebffc18310@qt.io> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8c47d452-ec30-4fa1-a131-caebffc18310@qt.io> User-Agent: Mutt/1.8.0 (2017-02-23) X-SW-Source: 2017-q2/txt/msg00096.txt.bz2 On Thu, Apr 20, 2017 at 03:47:49PM +0200, Ulf Hermann wrote: > Those are deprecated and apparently some implementations of nl_langinfo > return empty strings for them. The tests even tested for those empty > strings even though the intention of the code was clearly to output > "yes" or "no" there. Urgh. Good find. YESSTR and NOSTR were once meant for matching user input. Using them for output was probably always wrong. Pushed to master. Thanks, Mark