From: Mark Wielaard <mark@klomp.org>
To: Ulf Hermann <ulf.hermann@qt.io>
Cc: elfutils-devel@sourceware.org
Subject: Re: [PATCH] Avoid signed/unsigned comparison
Date: Thu, 27 Apr 2017 22:35:00 -0000 [thread overview]
Message-ID: <20170427182446.GD2061@stream> (raw)
In-Reply-To: <1544575c-bba2-f196-3485-eb56b206b3d0@qt.io>
On Thu, Apr 20, 2017 at 04:40:30PM +0200, Ulf Hermann wrote:
> Some compilers implicitly cast the result of uint_fast16_t *
> uint_fast16_t to something signed and then complain about the
> comparison to (unsigned) size_t.
Really? That is allowed? Using a signed type for uint_fast16_t?
> Casting phnum to size_t is a good idea anyway as 16bit multiplication
> can easily overflow and we are not checking for this.
OK, that seems an ok enough reason.
Applied to master.
Thanks,
Mark
next prev parent reply other threads:[~2017-04-27 18:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-20 14:40 Ulf Hermann
2017-04-27 22:35 ` Mark Wielaard [this message]
2017-04-28 10:35 ` Josh Stone
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170427182446.GD2061@stream \
--to=mark@klomp.org \
--cc=elfutils-devel@sourceware.org \
--cc=ulf.hermann@qt.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).