From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 36710 invoked by alias); 27 Apr 2017 22:35:53 -0000 Mailing-List: contact elfutils-devel-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Post: List-Help: List-Subscribe: Sender: elfutils-devel-owner@sourceware.org Received: (qmail 36527 invoked by uid 89); 27 Apr 2017 22:35:45 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.99.2 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY autolearn=no version=3.3.2 spammy=Applied X-Spam-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY autolearn=no version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on sourceware.org X-Spam-Level: X-HELO: gnu.wildebeest.org Date: Fri, 28 Apr 2017 08:51:00 -0000 From: Mark Wielaard To: Ulf Hermann Cc: elfutils-devel@sourceware.org Subject: Re: [PATCH] Fix nesting of braces Message-ID: <20170427223552.GG2061@stream> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.8.0 (2017-02-23) X-SW-Source: 2017-q2/txt/msg00118.txt.bz2 On Thu, Apr 27, 2017 at 04:35:23PM +0200, Ulf Hermann wrote: > The way it was before it didn't actually test if elf_update failed, but > rather did something random. !!() is a boolean and boolean > true can be represented as anything non-0, including negative numbers. Urgh. Another good find. Thanks. Applied to master.