From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24566 invoked by alias); 17 Jul 2017 22:24:54 -0000 Mailing-List: contact elfutils-devel-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Post: List-Help: List-Subscribe: Sender: elfutils-devel-owner@sourceware.org Received: (qmail 19568 invoked by uid 89); 17 Jul 2017 22:24:50 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.99.2 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=47pm, 47PM, Hx-languages-length:1385, H*c:application X-Spam-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on sourceware.org X-Spam-Level: X-HELO: vmicros1.altlinux.org Received: from vmicros1.altlinux.org (HELO vmicros1.altlinux.org) (194.107.17.57) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 17 Jul 2017 22:24:49 +0000 Received: from mua.local.altlinux.org (mua.local.altlinux.org [192.168.1.14]) by vmicros1.altlinux.org (Postfix) with ESMTP id CDCF272E20A; Tue, 18 Jul 2017 01:24:46 +0300 (MSK) Received: by mua.local.altlinux.org (Postfix, from userid 508) id BEA207CE58C; Tue, 18 Jul 2017 01:24:46 +0300 (MSK) Date: Mon, 17 Jul 2017 22:24:00 -0000 From: "Dmitry V. Levin" To: Mark Wielaard Cc: elfutils-devel@sourceware.org Subject: Re: [COMMITTED] backends: Swap sys/ptrace.h and asm/ptrace.h include order on s390. Message-ID: <20170717222446.GA12913@altlinux.org> Mail-Followup-To: Mark Wielaard , elfutils-devel@sourceware.org References: <1500306294-12809-1-git-send-email-mark@klomp.org> <20170717162948.GA8679@altlinux.org> <1500309707.14595.379.camel@klomp.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="IJpNTDwzlM2Ie8A6" Content-Disposition: inline In-Reply-To: <1500309707.14595.379.camel@klomp.org> X-IsSubscribed: yes X-SW-Source: 2017-q3/txt/msg00025.txt.bz2 --IJpNTDwzlM2Ie8A6 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-length: 1317 On Mon, Jul 17, 2017 at 06:41:47PM +0200, Mark Wielaard wrote: > On Mon, 2017-07-17 at 19:29 +0300, Dmitry V. Levin wrote: > > On Mon, Jul 17, 2017 at 05:44:54PM +0200, Mark Wielaard wrote: > > > glibc 2.26 changed the sys/ptrace.h header so that it cannot be inclu= ded > > > after asm/ptrace.h. We still need to include the kernel asm/ptrace.h = for > > > the ptrace_area definition. Including it after sys/ptrace.h works aga= inst > > > both old and new glibc. > >=20 > > If it's a glibc regression, shouldn't it be fixed on glibc side before > > 2.26 is out? >=20 > I asked and it was done deliberately. See glibc 2.26 NEWS under > Deprecated and removed features, and other changes affecting > compatibility. There are exactly two commits in glibc since 2.25 that changed sysdeps/unix/sysv/linux/s390/sys/ptrace.h: 3f67d1a7021ed3184830511636a0867faec730fe and b08a6a0dea63742313ed3d9577c1e2d83436b196. I reviewed and approved both of these commits assuming that they brought no regressions. If sys/ptrace.h from glibc 2.25 could be included before or after linux/ptrace.h, this shouldn't have changed in glibc 2.26. In other words, I think you've spotted a regression that I missed during b08a6a0dea63742313ed3d9577c1e2d83436b196 review and that has to be fixed in glibc before 2.26 is released. --=20 ldv --IJpNTDwzlM2Ie8A6 Content-Type: application/pgp-signature; name="signature.asc" Content-length: 801 -----BEGIN PGP SIGNATURE----- iQIcBAEBCAAGBQJZbTkuAAoJEAVFT+BVnCUIOYcQAINrtaBwqW+FECCQ7AXcG75g UNDpFhhQGkJHC73rqyqtwczMcH9hsDCpUgMBhsYupWYIcdbBIGF+zjyZtx1cqEoq aLiSM5nXu+1f2XLeG5tKk1WaqpB8bAU4gi4UEBTSa1R8JrNRPCPq9fpYQ9Xyufpk nJDseUYhSbEBjNdbLA388kdWFtwUWPFb7SkztdSiav3pDjzBf0208HWZgZeFusdC +9LJqe4+fKXdfbOwVwmoSioyXUN3lKGU6E24rOiNF4+XdV0d8hmxTo9wTIK0BoW9 axxXHdRg3jViEKa7mI+RWtbOVSNaKlgcktBMha6VvUsBAjiB5M4RnjA0z/KFb384 rkXDuarG8WeEK/Q6oOxC+cdHtBwhHXUV2oO0iuYp90vNNlr9tS0lCle0n8pSW7uw IrvPhJJkxmu30mPCIf6ODXPdGA3sAbIjCyz8mAVHff8cJrMZRkeYRDxQGN7an4P6 pZNAoX5v0hvdi5aQNsaTFlfaE1wNywtkzQu7DmkM75sjPEvQx3YtbXQj5lmhvnrX goPZ8sb7itsHpG2Owyd7kS7M+COWS5CDzTC6gRX8m6rJWkFWdRNfSZY3Fax/PGZ1 /3u2CPmtLg/P2ehzD/0zewCdqAB2EUpb2Tr4uYArkAbrUEkDuGg/JlKeWrNzp4Mm hNPyUW0vn0WuQAtOpcnH =5C4g -----END PGP SIGNATURE----- --IJpNTDwzlM2Ie8A6--