From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 124014 invoked by alias); 17 Jul 2017 22:52:42 -0000 Mailing-List: contact elfutils-devel-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Post: List-Help: List-Subscribe: Sender: elfutils-devel-owner@sourceware.org Received: (qmail 123966 invoked by uid 89); 17 Jul 2017 22:52:41 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.99.2 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY autolearn=no version=3.3.2 spammy=H*M:stream X-Spam-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY autolearn=no version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on sourceware.org X-Spam-Level: X-HELO: gnu.wildebeest.org Received: from wildebeest.demon.nl (HELO gnu.wildebeest.org) (212.238.236.112) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 17 Jul 2017 22:52:39 +0000 Received: from stream.wildebeest.org (deer0x13.wildebeest.org [172.31.17.149]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id EA535300070A; Tue, 18 Jul 2017 00:52:37 +0200 (CEST) Received: by stream.wildebeest.org (Postfix, from userid 1000) id 457D51007EB; Tue, 18 Jul 2017 00:52:51 +0200 (CEST) Date: Mon, 17 Jul 2017 22:52:00 -0000 From: Mark Wielaard To: "Dmitry V. Levin" Cc: elfutils-devel@sourceware.org Subject: Re: [COMMITTED] backends: Swap sys/ptrace.h and asm/ptrace.h include order on s390. Message-ID: <20170717225251.GC2236@stream> References: <1500306294-12809-1-git-send-email-mark@klomp.org> <20170717162948.GA8679@altlinux.org> <1500309707.14595.379.camel@klomp.org> <20170717222446.GA12913@altlinux.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170717222446.GA12913@altlinux.org> User-Agent: Mutt/1.8.3 (2017-05-23) X-IsSubscribed: yes X-SW-Source: 2017-q3/txt/msg00026.txt.bz2 On Tue, Jul 18, 2017 at 01:24:46AM +0300, Dmitry V. Levin wrote: > I reviewed and approved both of these commits assuming that they brought > no regressions. If sys/ptrace.h from glibc 2.25 could be included before > or after linux/ptrace.h, this shouldn't have changed in glibc 2.26. > > In other words, I think you've spotted a regression that I missed during > b08a6a0dea63742313ed3d9577c1e2d83436b196 review and that has to be fixed > in glibc before 2.26 is released. Aha. So if you look at that patch you see that the same include pattern that got us in trouble was removed from sysdeps/s390/fpu/fesetenv.c and the new order is used in the newly added testcase sysdeps/unix/sysv/linux/s390/tst-ptrace-singleblock.c. On fedora s390x rawhide (which has a glibc 2.16 pre-release) including asm/ptrace.h before sys/ptrace.h will cause errors: https://kojipkgs.fedoraproject.org//work/tasks/4924/20574924/build.log Cheers, Mark