From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 123154 invoked by alias); 24 Jul 2017 09:20:03 -0000 Mailing-List: contact elfutils-devel-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Post: List-Help: List-Subscribe: Sender: elfutils-devel-owner@sourceware.org Received: (qmail 123114 invoked by uid 89); 24 Jul 2017 09:20:01 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.99.2 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY autolearn=no version=3.3.2 spammy=H*M:stream, Feb, feb, H*r:sk:ADH-AES X-Spam-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY autolearn=no version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on sourceware.org X-Spam-Level: X-HELO: gnu.wildebeest.org Received: from wildebeest.demon.nl (HELO gnu.wildebeest.org) (212.238.236.112) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 24 Jul 2017 09:19:59 +0000 Received: from stream.wildebeest.org (ip4da134f7.direct-adsl.nl [77.161.52.247]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id E201330003AF; Mon, 24 Jul 2017 11:19:56 +0200 (CEST) Received: by stream.wildebeest.org (Postfix, from userid 1000) id 1BB271029FF; Mon, 24 Jul 2017 11:20:03 +0200 (CEST) Date: Mon, 24 Jul 2017 09:20:00 -0000 From: Mark Wielaard To: Ulf Hermann Cc: elfutils-devel@sourceware.org Subject: Re: [PATCH v2] Unify linking of libasm, libelf, libdw, backends Message-ID: <20170724092003.GA8002@stream> References: <90584aa0-6c04-ca62-9994-8b2ede687dc2@qt.io> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <90584aa0-6c04-ca62-9994-8b2ede687dc2@qt.io> User-Agent: Mutt/1.8.3 (2017-05-23) X-IsSubscribed: yes X-SW-Source: 2017-q3/txt/msg00036.txt.bz2 On Fri, Feb 17, 2017 at 04:11:28PM +0100, Ulf Hermann wrote: > Link them all with -z,defs,-z,relro,--no-undefined, provide complete > dependencies for the link steps, and add libeu.a to each one. libeu.a > contains useful library functionality that each of them might use. The > linker will strip unneeded symbols, so linking it in won't hurt even if > none of the functions are used. This is a nice cleanup. Sorry it took so long to review. Applied to master. Thanks, Mark