From: Mark Wielaard <mark@klomp.org>
To: Ulf Hermann <ulf.hermann@qt.io>
Cc: elfutils-devel@sourceware.org
Subject: Re: [PATCH v2] Check if gcc complains about __attribute__ (visibility(..))
Date: Sat, 19 Aug 2017 08:11:00 -0000 [thread overview]
Message-ID: <20170818203837.GB3169@stream> (raw)
In-Reply-To: <5e89ee5d-ecdf-1e3a-3e67-0d617b524da6@qt.io>
On Fri, Aug 18, 2017 at 01:06:36PM +0200, Ulf Hermann wrote:
> If so, define attribute_hidden to be empty. Also, use attribute_hidden
> in all places where we hide symbols. If this attribute is missing, it
> simply means that we cannot hide private symbols in the binary using
> attributes. This disables some optimizations and may increase the risk
> of symbol name clashes with other libraries, but is not fatal.
>
> However, we still employ linker version scripts to explicitly define
> the exported symbols. This serves much of the same purpose. Also, as
> all our symbols are prefixed with the library name, and "__" for
> private ones, the chance of clashes is low anyway.
Like the previous one, I have my doubts. But it actually makes the
source code slightly more consistent. So applied.
Thanks,
Mark
prev parent reply other threads:[~2017-08-19 8:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-18 11:06 Ulf Hermann
2017-08-19 8:11 ` Mark Wielaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170818203837.GB3169@stream \
--to=mark@klomp.org \
--cc=elfutils-devel@sourceware.org \
--cc=ulf.hermann@qt.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).