From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 61128 invoked by alias); 19 Aug 2017 08:17:36 -0000 Mailing-List: contact elfutils-devel-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Post: List-Help: List-Subscribe: Sender: elfutils-devel-owner@sourceware.org Received: (qmail 61095 invoked by uid 89); 19 Aug 2017 08:17:34 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.99.2 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=0.3 required=5.0 tests=AWL,BAYES_00,DATE_IN_PAST_06_12,KAM_LAZY_DOMAIN_SECURITY autolearn=no version=3.3.2 spammy=H*M:stream X-Spam-Status: No, score=0.3 required=5.0 tests=AWL,BAYES_00,DATE_IN_PAST_06_12,KAM_LAZY_DOMAIN_SECURITY autolearn=no version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on sourceware.org X-Spam-Level: X-HELO: gnu.wildebeest.org Received: from wildebeest.demon.nl (HELO gnu.wildebeest.org) (212.238.236.112) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 19 Aug 2017 08:17:32 +0000 Received: from stream.wildebeest.org (ADijon-357-1-27-209.w109-217.abo.wanadoo.fr [109.217.50.209]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id B2163304D6B7; Sat, 19 Aug 2017 10:11:04 +0200 (CEST) Received: by stream.wildebeest.org (Postfix, from userid 1000) id 5BF6E101FBE; Fri, 18 Aug 2017 23:12:01 +0200 (CEST) Date: Sat, 19 Aug 2017 08:17:00 -0000 From: Mark Wielaard To: Ulf Hermann Cc: elfutils-devel@sourceware.org Subject: Re: [PATCH] Drop *_so_SOURCES from libasm, libdw, libelf Makefile.am Message-ID: <20170818211201.GE3169@stream> References: <24542abd-4c9a-705d-a928-01605dc36b35@qt.io> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <24542abd-4c9a-705d-a928-01605dc36b35@qt.io> User-Agent: Mutt/1.8.3 (2017-05-23) X-IsSubscribed: yes X-SW-Source: 2017-q3/txt/msg00094.txt.bz2 On Fri, Aug 18, 2017 at 03:35:35PM +0200, Ulf Hermann wrote: > They aren't used and cause warnings from autoconf. Again I don't have internet access to lookup the autoconf manual. But I don't believe this is correct. Removing the so_SOURCES is not the same as leaving them empty. The change as proposed will break make dist (or make distcheck) because removing it seems to cause the default sources seem to be lib*.c. What warnings did it cause for you? I am not seeing any. Thanks, Mark