From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 126880 invoked by alias); 21 Dec 2017 20:22:38 -0000 Mailing-List: contact elfutils-devel-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Post: List-Help: List-Subscribe: Sender: elfutils-devel-owner@sourceware.org Received: (qmail 126861 invoked by uid 89); 21 Dec 2017 20:22:38 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.99.2 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY autolearn=no version=3.3.2 spammy= X-Spam-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY autolearn=no version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on sourceware.org X-Spam-Level: X-HELO: gnu.wildebeest.org Received: from wildebeest.demon.nl (HELO gnu.wildebeest.org) (212.238.236.112) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 21 Dec 2017 20:22:37 +0000 Received: from stream.wildebeest.org (deer0x13.wildebeest.org [172.31.17.149]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id 462FA30007B4; Thu, 21 Dec 2017 21:22:35 +0100 (CET) Received: by stream.wildebeest.org (Postfix, from userid 1000) id 5235D109649; Thu, 21 Dec 2017 21:22:42 +0100 (CET) Date: Thu, 21 Dec 2017 20:22:00 -0000 From: Mark Wielaard To: Ulf Hermann Cc: elfutils-devel@sourceware.org Subject: Re: [PATCH 1/2 v2] Don't overflow in __libdw_in_section Message-ID: <20171221202242.GB28804@stream> References: <5ae489eb-3981-24b4-294a-734b1c52731d@qt.io> <1513259021.15696.80.camel@klomp.org> <8b4e21a8-6328-5f05-664c-004d92461ed1@qt.io> <1513793099.3236.21.camel@klomp.org> <994f1c7b-b738-9403-b021-2a42167d468a@qt.io> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <994f1c7b-b738-9403-b021-2a42167d468a@qt.io> User-Agent: Mutt/1.9.1 (2017-09-22) X-Spam-Flag: NO X-IsSubscribed: yes X-SW-Source: 2017-q4/txt/msg00120.txt.bz2 On Thu, Dec 21, 2017 at 02:47:49PM +0100, Ulf Hermann wrote: > > It is surprising we didn't see more issues with this code. There is > > also the fake loc cu that fetches data from a different section. I > > updated both functions as attached. > > Looks good to me. Thanks for taking a look. Pushed to master.