From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 127389 invoked by alias); 21 Dec 2017 20:22:57 -0000 Mailing-List: contact elfutils-devel-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Post: List-Help: List-Subscribe: Sender: elfutils-devel-owner@sourceware.org Received: (qmail 127377 invoked by uid 89); 21 Dec 2017 20:22:56 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.99.2 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY autolearn=no version=3.3.2 spammy= X-Spam-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY autolearn=no version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on sourceware.org X-Spam-Level: X-HELO: gnu.wildebeest.org Received: from wildebeest.demon.nl (HELO gnu.wildebeest.org) (212.238.236.112) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 21 Dec 2017 20:22:55 +0000 Received: from stream.wildebeest.org (deer0x13.wildebeest.org [172.31.17.149]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id DBBAE30007B4; Thu, 21 Dec 2017 21:22:53 +0100 (CET) Received: by stream.wildebeest.org (Postfix, from userid 1000) id E882A109649; Thu, 21 Dec 2017 21:23:00 +0100 (CET) Date: Thu, 21 Dec 2017 20:22:00 -0000 From: Mark Wielaard To: Ulf Hermann Cc: elfutils-devel@sourceware.org Subject: Re: [PATCH 2/2 v2] Generalize cu_sec_idx Message-ID: <20171221202300.GC28804@stream> References: <1513259491.15696.82.camel@klomp.org> <7ba4e217-ebd7-1fea-31c7-5c2ff6ba166b@qt.io> <1513793336.3236.23.camel@klomp.org> <01ed1fca-c9de-c819-df7b-813c25b1da7c@qt.io> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <01ed1fca-c9de-c819-df7b-813c25b1da7c@qt.io> User-Agent: Mutt/1.9.1 (2017-09-22) X-Spam-Flag: NO X-IsSubscribed: yes X-SW-Source: 2017-q4/txt/msg00121.txt.bz2 On Thu, Dec 21, 2017 at 02:48:15PM +0100, Ulf Hermann wrote: > > yes, but the original code really was not correct. The attached patch > > fixes it by adding an explicit sec_idx field to the Dwarf_CU struct > > that is set whenever a struct Dwarf_CU is created, so that we never > > have to guess. > > > > This patch combined with the overflow fix makes all testcases PASS. > > Looks good to me. Thanks again. Pushed to master.