From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 92986 invoked by alias); 24 Dec 2017 15:10:43 -0000 Mailing-List: contact elfutils-devel-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Post: List-Help: List-Subscribe: Sender: elfutils-devel-owner@sourceware.org Received: (qmail 92971 invoked by uid 89); 24 Dec 2017 15:10:42 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.99.2 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,KAM_LAZY_DOMAIN_SECURITY autolearn=ham version=3.3.2 spammy=5156 X-Spam-Status: No, score=-25.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,KAM_LAZY_DOMAIN_SECURITY autolearn=ham version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on sourceware.org X-Spam-Level: X-HELO: gnu.wildebeest.org Received: from wildebeest.demon.nl (HELO gnu.wildebeest.org) (212.238.236.112) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 24 Dec 2017 15:10:41 +0000 Received: from stream.wildebeest.org (deer0x13.wildebeest.org [172.31.17.149]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id 34F0D300084C for ; Sun, 24 Dec 2017 16:10:37 +0100 (CET) Received: by stream.wildebeest.org (Postfix, from userid 1000) id 65482109676; Sun, 24 Dec 2017 16:10:45 +0100 (CET) Date: Sun, 24 Dec 2017 15:10:00 -0000 From: Mark Wielaard To: elfutils-devel@sourceware.org Subject: Re: [PATCH] tests: Try to use coredumpctl to extract core files. Message-ID: <20171224151045.GA27792@stream> References: <20171223223142.19835-1-mark@klomp.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171223223142.19835-1-mark@klomp.org> User-Agent: Mutt/1.9.1 (2017-09-22) X-Spam-Flag: NO X-IsSubscribed: yes X-SW-Source: 2017-q4/txt/msg00123.txt.bz2 On Sat, Dec 23, 2017 at 11:31:42PM +0100, Mark Wielaard wrote: > If systemd-coredump is installed we have to use coredumpctl to extract > the core file to test. Unfortunately systemd-coredump/coredumpctl seem > to be somewhat fragile if multiple core dumps are generated/extracted > at the same time. So use a lock file to only run one core dump test at > a time (under make -j). One small addition to appease make distcheck. We have to clean up the lock file. We don't want to make it a tempfile because we want the file to exist globally during all test runs. diff --git a/tests/Makefile.am b/tests/Makefile.am index fca00727..a9aa8bd4 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -515,6 +515,9 @@ dwarf_default_lower_bound_LDADD = $(libdw) system_elf_libelf_test_CPPFLAGS = system_elf_libelf_test_LDADD = $(libelf) +# A lock file used to make sure only one test dumps core at a time +CLEANFILES = core-dump-backtrace.lock + if GCOV check: check-am coverage .PHONY: coverage