From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 99623 invoked by alias); 23 Feb 2018 14:54:10 -0000 Mailing-List: contact elfutils-devel-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Post: List-Help: List-Subscribe: Sender: elfutils-devel-owner@sourceware.org Received: (qmail 99607 invoked by uid 89); 23 Feb 2018 14:54:09 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.99.2 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=HContent-Transfer-Encoding:8bit X-Spam-Status: No, score=-26.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on sourceware.org X-Spam-Level: X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 23 Feb 2018 14:54:08 +0000 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 3D2828F90F for ; Fri, 23 Feb 2018 14:54:07 +0000 (UTC) Received: from t470.redhat.com (ovpn-117-5.phx2.redhat.com [10.3.117.5]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5F9FF60C8A; Fri, 23 Feb 2018 14:54:06 +0000 (UTC) From: David Malcolm To: elfutils-devel@sourceware.org Cc: David Malcolm Subject: [PATCH, dwarflint] Explicitly qualify specializations of elfutils::to_string Date: Fri, 23 Feb 2018 14:54:00 -0000 Message-Id: <20180223145402.12470-1-dmalcolm@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Fri, 23 Feb 2018 14:54:07 +0000 (UTC) X-SW-Source: 2018-q1/txt/msg00050.txt.bz2 I attempted to build the "dwarflint" branch with gcc 7.3.1 , but ran into various problems of the form: c++/known.cc:220:1: error: explicit specialization of ‘template std::__cxx11::string elfutils::to_string(const type&)’ outside its namespace must use a nested-name-specifier [-fpermissive] to_string (const dwarf::dwarf_enum &value) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ The fix appears to be trivial. libdw/ChangeLog: * c++/edit-values.cc (to_string): Explicitly qualify with "elfutils::". * c++/known.cc (to_string): Likewise. (to_string): Likewise. * c++/output-values.cc (to_string): Likewise. * c++/values.cc (to_string): Likewise. (to_string): Likewise. (to_string): Likewise. (to_string): Likewise. Signed-off-by: David Malcolm --- libdw/c++/edit-values.cc | 2 +- libdw/c++/known.cc | 4 ++-- libdw/c++/output-values.cc | 2 +- libdw/c++/values.cc | 8 ++++---- 4 files changed, 8 insertions(+), 8 deletions(-) diff --git a/libdw/c++/edit-values.cc b/libdw/c++/edit-values.cc index aefb5fd1..ca83a967 100644 --- a/libdw/c++/edit-values.cc +++ b/libdw/c++/edit-values.cc @@ -41,7 +41,7 @@ template class dwarf_data::value; template<> std::string -to_string (const dwarf_edit::attribute &attr) +elfutils::to_string (const dwarf_edit::attribute &attr) { return attribute_string (attr); } diff --git a/libdw/c++/known.cc b/libdw/c++/known.cc index bd84f52c..cb5fe693 100644 --- a/libdw/c++/known.cc +++ b/libdw/c++/known.cc @@ -217,14 +217,14 @@ enum_string (const value_type &value) template<> string -to_string (const dwarf::dwarf_enum &value) +elfutils::to_string (const dwarf::dwarf_enum &value) { return enum_string (value); } template<> string -to_string (const dwarf_data::dwarf_enum &value) +elfutils::to_string (const dwarf_data::dwarf_enum &value) { return enum_string (value); } diff --git a/libdw/c++/output-values.cc b/libdw/c++/output-values.cc index 199c72bd..60abc0b5 100644 --- a/libdw/c++/output-values.cc +++ b/libdw/c++/output-values.cc @@ -46,7 +46,7 @@ template class dwarf_output::copier; template<> std::string -to_string (const dwarf_output::attribute &attr) +elfutils::to_string (const dwarf_output::attribute &attr) { return attribute_string (attr); } diff --git a/libdw/c++/values.cc b/libdw/c++/values.cc index 335074fb..c70d793f 100644 --- a/libdw/c++/values.cc +++ b/libdw/c++/values.cc @@ -227,28 +227,28 @@ value_string (const value_type &value) template<> string -to_string (const dwarf::attribute &attr) +elfutils::to_string (const dwarf::attribute &attr) { return attribute_string (attr); } template<> string -to_string (const dwarf::attr_value &value) +elfutils::to_string (const dwarf::attr_value &value) { return value_string (value); } template<> string -to_string (const dwarf_edit::attr_value &value) +elfutils::to_string (const dwarf_edit::attr_value &value) { return value_string (value); } template<> string -to_string (const dwarf_output::attr_value &value) +elfutils::to_string (const dwarf_output::attr_value &value) { return value_string (value); } -- 2.13.6