public inbox for elfutils@sourceware.org
 help / color / mirror / Atom feed
From: Mark Wielaard <mark@klomp.org>
To: Milian Wolff <mail@milianw.de>
Cc: elfutils-devel@sourceware.org
Subject: Re: How to associate Elf with Dwfl_Module returned by dwfl_report_module
Date: Wed, 21 Mar 2018 21:31:00 -0000	[thread overview]
Message-ID: <20180321213107.GK6269@wildebeest.org> (raw)
In-Reply-To: <1581387.j5xz9UsgaX@agathebauer>

On Wed, Mar 21, 2018 at 03:23:51PM +0100, Milian Wolff wrote:
> Here's one way to investigate where perf and dwfl disagree on the file 
> mappings:
> 
> diff --git a/tools/perf/util/unwind-libdw.c b/tools/perf/util/unwind-libdw.c
> index 7bdd239c795c..739c68b73772 100644
> --- a/tools/perf/util/unwind-libdw.c
> +++ b/tools/perf/util/unwind-libdw.c
> @@ -48,11 +48,17 @@ static int __report_module(struct addr_location *al, u64 
> ip,
>  			mod = 0;
>  	}
>  
> -	if (!mod)
> +	if (!mod) {
> +		Dwarf_Addr s, e;
>  		mod = dwfl_report_elf(ui->dwfl, dso->short_name,
>  				      (dso->symsrc_filename ? dso->symsrc_filename : dso-
> >long_name), -1, al->map->start,
>  				      false);
>  
> +		dwfl_module_info(mod, NULL, &s, &e, NULL, NULL, NULL, NULL);
> +		if (al->map->start != s || al->map->end != e)
> +			pr_warning("MEH: %s | mmap: %zx %zx | dwfl: %zx %zx\n", dso-
> >short_name, al->map->start, al->map->end, s, e);
> +	}
> +
>  	return mod && dwfl_addrmodule(ui->dwfl, ip) == mod ? 0 : -1;
>  }
>  
> On one of my perf.data files with many broken backtraces this gives me:
> 
> MEH: heaptrack_print | mmap: 56166e9d4000 56166ea39000 | dwfl: 56166e9d4000 
> 56166ea38880
> MEH: ld-2.26.so | mmap: 7fd0afc6c000 7fd0afe93000 | dwfl: 7fd0afc6c000 
> 7fd0afe920f8
> MEH: libc-2.26.so | mmap: 7fd0ae16a000 7fd0ae521000 | dwfl: 7fd0ae16a000 
> 7fd0ae5208f0
> MEH: libstdc++.so.6.0.24 | mmap: 7fd0aea84000 7fd0aee0b000 | dwfl: 
> 7fd0aea84000 7fd0aee0a640
> MEH: libzstd.so.1.3.3 | mmap: 7fd0aee0b000 7fd0af087000 | dwfl: 7fd0aee0b000 
> 7fd0af086030
> 
> Interestingly, here the mmap events observed by perf are actually always 
> *larger* than what dwfl sees...

I think that is simply the end address being extended to the next page.
Where the page size seems to be 4K (0x1000). I assume if you look at
the actual LOAD segment sizes of the files (eu-readelf -l) they match
with what dwfl reports, and if it extends to the nearest 4k page it
matches whatp mmap reports.

Cheers,

Mark

  parent reply	other threads:[~2018-03-21 21:31 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-17 13:15 Milian Wolff
2018-03-20 22:05 ` Mark Wielaard
2018-03-21 13:01   ` Milian Wolff
2018-03-21 14:23     ` Milian Wolff
2018-03-21 14:35       ` Ulf Hermann
2018-03-21 21:31       ` Mark Wielaard [this message]
2018-03-22 12:30         ` Milian Wolff
2018-03-21 21:21     ` Mark Wielaard
2018-03-22 12:29       ` Milian Wolff
2018-03-22  9:11     ` Ulf Hermann
2018-03-22 12:33       ` Milian Wolff

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180321213107.GK6269@wildebeest.org \
    --to=mark@klomp.org \
    --cc=elfutils-devel@sourceware.org \
    --cc=mail@milianw.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).