From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17403 invoked by alias); 23 Apr 2018 16:59:51 -0000 Mailing-List: contact elfutils-devel-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Post: List-Help: List-Subscribe: Sender: elfutils-devel-owner@sourceware.org Received: (qmail 17326 invoked by uid 89); 23 Apr 2018 16:59:47 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.99.4 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.1 required=5.0 tests=BAYES_00,KAM_ASCII_DIVIDERS,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=no version=3.3.2 spammy=Assertion, emulation, aborted X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,KAM_ASCII_DIVIDERS,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=no version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on sourceware.org X-Spam-Level: X-HELO: gnu.wildebeest.org Received: from wildebeest.demon.nl (HELO gnu.wildebeest.org) (212.238.236.112) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 23 Apr 2018 16:59:45 +0000 Received: from librem.wildebeest.org (5ee53fc3.ftth.concepts.nl [94.229.63.195]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id 39BE6302BB23; Mon, 23 Apr 2018 18:59:42 +0200 (CEST) Received: by librem.wildebeest.org (Postfix, from userid 1000) id CC89F141353; Mon, 23 Apr 2018 18:59:41 +0200 (CEST) Date: Mon, 23 Apr 2018 16:59:00 -0000 From: Mark Wielaard To: Andreas Schwab Cc: elfutils-devel@sourceware.org Subject: Re: [PATCH] Add support for RISC-V Message-ID: <20180423165941.GB15873@wildebeest.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-Spam-Flag: NO X-IsSubscribed: yes X-SW-Source: 2018-q2/txt/msg00018.txt.bz2 Hi Andreas, On Thu, Apr 19, 2018 at 05:47:52PM +0200, Andreas Schwab wrote: > This implements initial support for the RISC-V architecture. It has > been tested with qemu linux-user emulation > , > with the following unresolved issues This is a great start. The patch looks fine. I only had to add the new testfile to EXTRA_DISTS. Pushed to master. > FAIL: run-strip-strmerge.sh > =========================== > > elflint /home/abuild/rpmbuild/BUILD/elfutils-0.170/tests/elfstrmerge > section [32] '.symtab': _GLOBAL_OFFSET_TABLE_ symbol value 0x51c0 does not match .got section address 0x5010 > section [32] '.symtab': symbol 119: st_value out of bounds > FAIL run-strip-strmerge.sh (exit status: 1) If you know the rules for _GLOBAL_OFFSET_TABLE you can write a check_special_symbol hook. Maybe symbol 119 is also special? > FAIL: run-elflint-self.sh > ========================= > > section [33] '.symtab': _GLOBAL_OFFSET_TABLE_ symbol value 0x6220 does not match .got section address 0x6008 > section [33] '.symtab': symbol 135: st_value out of bounds Likewise. > FAIL: run-native-test.sh > ======================== > > /home/abuild/rpmbuild/BUILD/elfutils-0.170/tests/allregs: dwfl_module_register_names: no backend registers known > FAIL run-native-test.sh (exit status: 1) This needs a register_info hook. > FAIL: run-backtrace-native-core.sh > ================================== > > backtrace: backtrace.c:111: callback_verify: Assertion `symname && strcmp (symname, "raise") == 0' failed. > ./test-subr.sh: line 84: 26040 Aborted (core dumped) LD_LIBRARY_PATH="${built_library_path}${LD_LIBRARY_PATH:+:}$LD_LIBRARY_PATH" $VALGRIND_CMD "$@" > backtrace-child-core.26027: no main > rmdir: failed to remove 'test-26016': Directory not empty > FAIL run-backtrace-native-core.sh (exit status: 1) This probably needs an abi_cfi hook and setting up the frame_nregs field. > In addition, all tests that use ptrace are failing as linux-user > emulation does not implement it. And it would need an set_initial_registers_tid hook and possible a fallback unwind hook. Cheers, Mark