From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 61575 invoked by alias); 20 May 2018 21:46:07 -0000 Mailing-List: contact elfutils-devel-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Post: List-Help: List-Subscribe: Sender: elfutils-devel-owner@sourceware.org Received: (qmail 61330 invoked by uid 89); 20 May 2018 21:45:32 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.99.4 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=fairly, 42pm, 42PM X-Spam-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on sourceware.org X-Spam-Level: X-HELO: gnu.wildebeest.org Received: from wildebeest.demon.nl (HELO gnu.wildebeest.org) (212.238.236.112) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 20 May 2018 21:45:31 +0000 Received: from librem.wildebeest.org (ip4da134f7.direct-adsl.nl [77.161.52.247]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id 2882430277C7 for ; Sun, 20 May 2018 23:45:16 +0200 (CEST) Received: by librem.wildebeest.org (Postfix, from userid 1000) id 34E7813FC06; Sun, 20 May 2018 23:45:16 +0200 (CEST) Date: Sun, 20 May 2018 21:46:00 -0000 From: Mark Wielaard To: elfutils-devel@sourceware.org Subject: Re: [PATCH] libdw: Cache ELF directory early. Explicitly set it in dwfl. Message-ID: <20180520214516.GA26110@wildebeest.org> References: <1526579022-4486-1-git-send-email-mark@klomp.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1526579022-4486-1-git-send-email-mark@klomp.org> User-Agent: Mutt/1.9.5 (2018-04-13) X-Spam-Flag: NO X-IsSubscribed: yes X-SW-Source: 2018-q2/txt/msg00067.txt.bz2 On Thu, May 17, 2018 at 07:43:42PM +0200, Mark Wielaard wrote: > The logic that finds alt files and dwo files relies on having an open > file descriptor. But after all needed ELF data has been read the > underlying Elf file descriptor can be closed. libdwfl in particular > closes file descriptor fairly aggressively. So capture the directory > early on. And make dwfl set it if it has recorded it. Which it will > do now before closing a file descriptor for the main Dwfl_Module file. Pushed to master.