From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26914 invoked by alias); 10 Jun 2018 15:21:20 -0000 Mailing-List: contact elfutils-devel-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Post: List-Help: List-Subscribe: Sender: elfutils-devel-owner@sourceware.org Received: (qmail 26888 invoked by uid 89); 10 Jun 2018 15:21:17 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.99.4 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:755 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on sourceware.org X-Spam-Level: X-HELO: gnu.wildebeest.org Received: from wildebeest.demon.nl (HELO gnu.wildebeest.org) (212.238.236.112) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 10 Jun 2018 15:21:16 +0000 Received: from librem.wildebeest.org (deer0x15.wildebeest.org [172.31.17.151]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id 19DE33014705 for ; Sun, 10 Jun 2018 17:21:13 +0200 (CEST) Received: by librem.wildebeest.org (Postfix, from userid 1000) id BE581141A87; Sun, 10 Jun 2018 17:21:13 +0200 (CEST) Date: Sun, 10 Jun 2018 15:21:00 -0000 From: Mark Wielaard To: elfutils-devel@sourceware.org Subject: Re: [PATCH] readelf, libdw: Handle too many directories or files in the line table better. Message-ID: <20180610152113.GA7539@wildebeest.org> References: <1528466789-18333-1-git-send-email-mark@klomp.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1528466789-18333-1-git-send-email-mark@klomp.org> User-Agent: Mutt/1.9.5 (2018-04-13) X-Spam-Flag: NO X-IsSubscribed: yes X-SW-Source: 2018-q2/txt/msg00196.txt.bz2 On Fri, Jun 08, 2018 at 04:06:29PM +0200, Mark Wielaard wrote: > The afl fuzzer found that the way we handle "too many" directories or files > in the (DWARF5 style) line table badly. In the case of eu-readelf we would > print an endless stream of "bad directory" or "bad file". Just stop printing > when the end of data is reached. In the case of dwarf_getsrclines we would > allocate a giant amount of memory, even if there was no data to actually > read in. Sanity check that the directory and file counts seem reasonable > compared to the amount of data left (assume we need at least 1 byte of > data per form describing the dirs or files). Pushed to master.