From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 130055 invoked by alias); 17 Jun 2018 18:39:30 -0000 Mailing-List: contact elfutils-devel-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Post: List-Help: List-Subscribe: Sender: elfutils-devel-owner@sourceware.org Received: (qmail 130042 invoked by uid 89); 17 Jun 2018 18:39:30 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.99.4 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=pushed, readelf, Hx-languages-length:561 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on sourceware.org X-Spam-Level: X-HELO: gnu.wildebeest.org Received: from wildebeest.demon.nl (HELO gnu.wildebeest.org) (212.238.236.112) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 17 Jun 2018 18:39:29 +0000 Received: from librem.wildebeest.org (deer0x15.wildebeest.org [172.31.17.151]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id 11CAD3002044 for ; Sun, 17 Jun 2018 20:39:27 +0200 (CEST) Received: by librem.wildebeest.org (Postfix, from userid 1000) id BAB8814017A; Sun, 17 Jun 2018 20:39:26 +0200 (CEST) Date: Sun, 17 Jun 2018 18:39:00 -0000 From: Mark Wielaard To: elfutils-devel@sourceware.org Subject: Re: [PATCH] libdw, readelf: Don't handle DW_FORM_data16 as expression block/location. Message-ID: <20180617183926.GB8502@wildebeest.org> References: <1529073014-6747-1-git-send-email-mark@klomp.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1529073014-6747-1-git-send-email-mark@klomp.org> User-Agent: Mutt/1.9.5 (2018-04-13) X-Spam-Flag: NO X-IsSubscribed: yes X-SW-Source: 2018-q2/txt/msg00230.txt.bz2 On Fri, Jun 15, 2018 at 04:30:14PM +0200, Mark Wielaard wrote: > Also found by afl-fuzz on the varlocs testcase. > DW_FORM_data16 is constant from according to the DWARF5 spec. > But since it is 128bits it isn't really representable as Dwarf_Word. > So we treat it as block form. But we cannot treat it as an expression > block. Make sure readelf prints it as a regular block and that > dwarf_getlocation[s|_addr] doesn't treat it as location expression. Pushed to master.