public inbox for elfutils@sourceware.org
 help / color / mirror / Atom feed
From: Mark Wielaard <mark@klomp.org>
To: Ross Burton <ross.burton@intel.com>
Cc: elfutils-devel@sourceware.org
Subject: Re: [PATCH 2/2] Consolidate error.h inclusion in system.h
Date: Thu, 05 Jul 2018 19:19:00 -0000	[thread overview]
Message-ID: <20180705191913.GF7556@wildebeest.org> (raw)
In-Reply-To: <20180704111108.21448-2-ross.burton@intel.com>

On Wed, Jul 04, 2018 at 12:11:08PM +0100, Ross Burton wrote:
> error.h isn't standard and so isn't part of the musl C library.  To easy future
> porting, consolidate the inclusion of error.h into system.h.
> 
> https://sourceware.org/bugzilla/show_bug.cgi?id=21008

Thanks, added ChangeLog entries and pushed to master.

But this isn't real solution. error is a useful GNU extension
that is widely used in the code base. So I think if you really
do want to use an alternative glibc implementation that it should
just provide error.

Cheers,

Mark

  reply	other threads:[~2018-07-05 19:19 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-04 11:11 [PATCH 1/2] Require gawk in maintainer mode Ross Burton
2018-07-04 11:11 ` [PATCH 2/2] Consolidate error.h inclusion in system.h Ross Burton
2018-07-05 19:19   ` Mark Wielaard [this message]
2018-07-05 18:16 ` [PATCH 1/2] Require gawk in maintainer mode Mark Wielaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180705191913.GF7556@wildebeest.org \
    --to=mark@klomp.org \
    --cc=elfutils-devel@sourceware.org \
    --cc=ross.burton@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).