From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15580 invoked by alias); 5 Jul 2018 19:19:18 -0000 Mailing-List: contact elfutils-devel-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Post: List-Help: List-Subscribe: Sender: elfutils-devel-owner@sourceware.org Received: (qmail 15098 invoked by uid 89); 5 Jul 2018 19:19:17 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.99.4 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy= X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on sourceware.org X-Spam-Level: X-HELO: gnu.wildebeest.org Received: from wildebeest.demon.nl (HELO gnu.wildebeest.org) (212.238.236.112) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 05 Jul 2018 19:19:16 +0000 Received: from librem.wildebeest.org (deer0x15.wildebeest.org [172.31.17.151]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id ECA993000910; Thu, 5 Jul 2018 21:19:13 +0200 (CEST) Received: by librem.wildebeest.org (Postfix, from userid 1000) id 89EBA1411AE; Thu, 5 Jul 2018 21:19:13 +0200 (CEST) Date: Thu, 05 Jul 2018 19:19:00 -0000 From: Mark Wielaard To: Ross Burton Cc: elfutils-devel@sourceware.org Subject: Re: [PATCH 2/2] Consolidate error.h inclusion in system.h Message-ID: <20180705191913.GF7556@wildebeest.org> References: <20180704111108.21448-1-ross.burton@intel.com> <20180704111108.21448-2-ross.burton@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180704111108.21448-2-ross.burton@intel.com> User-Agent: Mutt/1.10.0 (2018-05-17) X-Spam-Flag: NO X-IsSubscribed: yes X-SW-Source: 2018-q3/txt/msg00010.txt.bz2 On Wed, Jul 04, 2018 at 12:11:08PM +0100, Ross Burton wrote: > error.h isn't standard and so isn't part of the musl C library. To easy future > porting, consolidate the inclusion of error.h into system.h. > > https://sourceware.org/bugzilla/show_bug.cgi?id=21008 Thanks, added ChangeLog entries and pushed to master. But this isn't real solution. error is a useful GNU extension that is widely used in the code base. So I think if you really do want to use an alternative glibc implementation that it should just provide error. Cheers, Mark