From: Mark Wielaard <mark@klomp.org>
To: Ulf Hermann <ulf.hermann@qt.io>
Cc: elfutils-devel@sourceware.org
Subject: Re: [PATCH 1/2] Remove previous test files before running the next round
Date: Mon, 16 Jul 2018 21:58:00 -0000 [thread overview]
Message-ID: <20180716215755.GA8971@wildebeest.org> (raw)
In-Reply-To: <87ac4132-25a7-cb0a-e3f0-a6c5495f0426@qt.io>
On Mon, Jul 16, 2018 at 12:01:21PM +0200, Ulf Hermann wrote:
> strip explicitly creates the new files. This will not work on windows if
> the files already exist.
>
> Also, if strip fails to create the files for any reason, we would check
> the previous run's files and succeed. However, the test should fail
> then.
This makes sense and does uncover a bug as your second patch shows.
I want to fix that first and only then commit this fix. That way we
don't have the testsuite failing between commits.
Thanks,
Mark
next prev parent reply other threads:[~2018-07-16 21:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-16 10:01 Ulf Hermann
2018-07-16 21:58 ` Mark Wielaard [this message]
2018-07-17 10:33 ` Mark Wielaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180716215755.GA8971@wildebeest.org \
--to=mark@klomp.org \
--cc=elfutils-devel@sourceware.org \
--cc=ulf.hermann@qt.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).