From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 49089 invoked by alias); 16 Jul 2018 21:58:00 -0000 Mailing-List: contact elfutils-devel-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Post: List-Help: List-Subscribe: Sender: elfutils-devel-owner@sourceware.org Received: (qmail 49055 invoked by uid 89); 16 Jul 2018 21:57:59 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.100.0 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=uncover X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on sourceware.org X-Spam-Level: X-HELO: gnu.wildebeest.org Received: from wildebeest.demon.nl (HELO gnu.wildebeest.org) (212.238.236.112) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 16 Jul 2018 21:57:58 +0000 Received: from librem.wildebeest.org (deer0x15.wildebeest.org [172.31.17.151]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id A813D30002FA; Mon, 16 Jul 2018 23:57:55 +0200 (CEST) Received: by librem.wildebeest.org (Postfix, from userid 1000) id 406CA13F8C2; Mon, 16 Jul 2018 23:57:55 +0200 (CEST) Date: Mon, 16 Jul 2018 21:58:00 -0000 From: Mark Wielaard To: Ulf Hermann Cc: elfutils-devel@sourceware.org Subject: Re: [PATCH 1/2] Remove previous test files before running the next round Message-ID: <20180716215755.GA8971@wildebeest.org> References: <87ac4132-25a7-cb0a-e3f0-a6c5495f0426@qt.io> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87ac4132-25a7-cb0a-e3f0-a6c5495f0426@qt.io> User-Agent: Mutt/1.10.0 (2018-05-17) X-Spam-Flag: NO X-IsSubscribed: yes X-SW-Source: 2018-q3/txt/msg00019.txt.bz2 On Mon, Jul 16, 2018 at 12:01:21PM +0200, Ulf Hermann wrote: > strip explicitly creates the new files. This will not work on windows if > the files already exist. > > Also, if strip fails to create the files for any reason, we would check > the previous run's files and succeed. However, the test should fail > then. This makes sense and does uncover a bug as your second patch shows. I want to fix that first and only then commit this fix. That way we don't have the testsuite failing between commits. Thanks, Mark