From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28038 invoked by alias); 8 Jan 2019 22:58:43 -0000 Mailing-List: contact elfutils-devel-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Post: List-Help: List-Subscribe: Sender: elfutils-devel-owner@sourceware.org Received: (qmail 28021 invoked by uid 89); 8 Jan 2019 22:58:42 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.100.2 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_PASS autolearn=ham version=3.3.2 spammy=school, reading X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_PASS autolearn=ham version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on sourceware.org X-Spam-Level: X-HELO: gnu.wildebeest.org Received: from wildebeest.demon.nl (HELO gnu.wildebeest.org) (212.238.236.112) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 08 Jan 2019 22:58:41 +0000 Received: from librem.wildebeest.org (deer0x15.wildebeest.org [172.31.17.151]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id 23D31323AB58; Tue, 8 Jan 2019 23:58:38 +0100 (CET) Received: by librem.wildebeest.org (Postfix, from userid 1000) id B4277140008; Tue, 8 Jan 2019 23:58:38 +0100 (CET) Date: Tue, 08 Jan 2019 22:58:00 -0000 From: Mark Wielaard To: Jim Wilson Cc: elfutils-devel@sourceware.org Subject: Re: [PATCH] RISC-V: Improve riscv64 core file support. Message-ID: <20190108225838.GA14235@wildebeest.org> References: <20181227232549.16635-1-jimw@sifive.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181227232549.16635-1-jimw@sifive.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Spam-Flag: NO X-IsSubscribed: yes X-SW-Source: 2019-q1/txt/msg00011.txt.bz2 On Thu, Dec 27, 2018 at 03:25:49PM -0800, Jim Wilson wrote: > This fixes two problems. The offset for x1 is changed from 1 to 8 because this > is a byte offset not a register skip count. Support for reading the PC value > is added. This requires changing the testsuite to match the new readelf > output for coredumps. This commit looks perfect (but please keep the lines a bit smaller, so git show looks ok on a 80 char term - yeah, I know how old school). Pushed to master. Thanks, Mark