From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 127636 invoked by alias); 13 Jan 2019 10:12:43 -0000 Mailing-List: contact elfutils-devel-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Post: List-Help: List-Subscribe: Sender: elfutils-devel-owner@sourceware.org Received: (qmail 127624 invoked by uid 89); 13 Jan 2019 10:12:42 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.100.2 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_PASS autolearn=ham version=3.3.2 spammy= X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_PASS autolearn=ham version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on sourceware.org X-Spam-Level: X-HELO: gnu.wildebeest.org Received: from wildebeest.demon.nl (HELO gnu.wildebeest.org) (212.238.236.112) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 13 Jan 2019 10:12:41 +0000 Received: from librem.wildebeest.org (unknown [145.15.244.28]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id 7E8C7302773A; Sun, 13 Jan 2019 11:12:39 +0100 (CET) Received: by librem.wildebeest.org (Postfix, from userid 1000) id 6D9BC1419A4; Sun, 13 Jan 2019 11:12:38 +0100 (CET) Date: Sun, 13 Jan 2019 10:12:00 -0000 From: Mark Wielaard To: Jim Wilson Cc: elfutils-devel@sourceware.org Subject: Re: [PATCH] RISC-V: Add untested 32-bit core file support. Message-ID: <20190113101238.GD9533@wildebeest.org> References: <20181227232702.16823-1-jimw@sifive.com> <610f78bbaaa4558d69b6c20e244a0b8416f3c3a7.camel@klomp.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-Spam-Flag: NO X-IsSubscribed: yes X-SW-Source: 2019-q1/txt/msg00034.txt.bz2 On Sat, Jan 12, 2019 at 04:37:51PM -0800, Jim Wilson wrote: > On Sat, Jan 12, 2019 at 2:29 PM Mark Wielaard wrote: > > > static const Ebl_Register_Location prstatus_regs[] = > > > { > > > - { .offset = 8, .regno = 1, .count = 31, .bits = 64 } /* x1..x31 */ > > > + { .offset = BITS/8, .regno = 1, .count = 31, .bits = 64 } /* x1..x31 */ > > > }; > > > > Should that be .bits = BITS ? > > Yes, sorry, I was looking at the offset field and completely missed > the bits member at the end. Do you want me to submit an updated > patch? I fixed it up and pushed the commit. It looks fine otherwise. Thanks, Mark