From: Yonghong Song <yhs@fb.com>
To: <elfutils-devel@sourceware.org>, <ast@fb.com>
Cc: <yhs@fb.com>
Subject: [PATCH elfutils 0/2] fix two /proc/pid/maps inode parsing issues
Date: Fri, 25 Jan 2019 21:20:00 -0000 [thread overview]
Message-ID: <20190125212009.2775258-1-yhs@fb.com> (raw)
The inode number in /proc/pid/maps has type "unsigned long".
The current parsing in libdwfl/linux-proc-maps.c and
tests/backtrace-data.c is not correct and it triggered
the following four test failures in one x64 box.
FAIL: dwfl-bug-fd-leak
FAIL: run-backtrace-data.sh
FAIL: run-backtrace-dwarf.sh
FAIL: vdsosyms
The offending map entry
7f269223d000-7f269226b000 r-xp 00000000 00:50 10224326387095067468 /home/...
has an inode number beyond the valid range of type "long".
This patch set fixed the problem in libdwfl and tests respectively.
Yonghong Song (2):
[libdwfl] parse inode in /proc/pid/maps correctly
[tests] parse inode in /proc/pid/maps correctly in
run-backtrace-data.sh
libdwfl/linux-proc-maps.c | 2 +-
tests/backtrace-data.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
--
2.17.1
next reply other threads:[~2019-01-25 21:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-25 21:20 Yonghong Song [this message]
2019-01-25 21:20 ` [PATCH elfutils 2/2] [tests] parse inode in /proc/pid/maps correctly in run-backtrace-data.sh Yonghong Song
2019-01-29 20:50 ` Mark Wielaard
2019-01-29 21:23 ` Yonghong Song
2019-01-31 21:14 ` Mark Wielaard
2019-01-31 22:26 ` Mark Wielaard
2019-01-25 21:20 ` [PATCH elfutils 1/2] [libdwfl] parse inode in /proc/pid/maps correctly Yonghong Song
2019-01-29 20:10 ` Mark Wielaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190125212009.2775258-1-yhs@fb.com \
--to=yhs@fb.com \
--cc=ast@fb.com \
--cc=elfutils-devel@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).