From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 86162 invoked by alias); 29 Jan 2019 20:10:19 -0000 Mailing-List: contact elfutils-devel-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Post: List-Help: List-Subscribe: Sender: elfutils-devel-owner@sourceware.org Received: (qmail 86150 invoked by uid 89); 29 Jan 2019 20:10:18 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.100.2 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_PASS autolearn=ham version=3.3.2 spammy=offending, Hx-languages-length:741, our X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_PASS autolearn=ham version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on sourceware.org X-Spam-Level: X-HELO: gnu.wildebeest.org Received: from wildebeest.demon.nl (HELO gnu.wildebeest.org) (212.238.236.112) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 29 Jan 2019 20:10:17 +0000 Received: from librem.wildebeest.org (deer0x15.wildebeest.org [172.31.17.151]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id B2E4E302BBFE; Tue, 29 Jan 2019 21:10:15 +0100 (CET) Received: by librem.wildebeest.org (Postfix, from userid 1000) id 5B78113FB04; Tue, 29 Jan 2019 21:10:15 +0100 (CET) Date: Tue, 29 Jan 2019 20:10:00 -0000 From: Mark Wielaard To: Yonghong Song Cc: elfutils-devel@sourceware.org, ast@fb.com Subject: Re: [PATCH elfutils 1/2] [libdwfl] parse inode in /proc/pid/maps correctly Message-ID: <20190129201015.GJ9378@wildebeest.org> References: <20190125212009.2775258-1-yhs@fb.com> <20190125212009.2775258-2-yhs@fb.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190125212009.2775258-2-yhs@fb.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Spam-Flag: NO X-IsSubscribed: yes X-SW-Source: 2019-q1/txt/msg00100.txt.bz2 On Fri, Jan 25, 2019 at 01:20:08PM -0800, Yonghong Song wrote: > The inode number in /proc/pid/maps is displayed as "unsigned long" > type. > > In one of our x64 system, we have inode number exceeding valid "long" > type range, which caused the following test failure: > FAIL: dwfl-bug-fd-leak > FAIL: run-backtrace-dwarf.sh > FAIL: vdsosyms > > The offending map entry: > 7f269246b000-7f269246c000 rw-p 0002e000 00:50 10224326387095067468 /home/... > > This patch changed sscanf inode number type from PRIi64 to PRIu64 > and fixed the problem. Reading the inode number as a signed value was indeed odd. Added a ChangeLog entry and pused to master. Thanks, Mark