From: Mark Wielaard <mark@klomp.org>
To: Yonghong Song <yhs@fb.com>
Cc: elfutils-devel@sourceware.org, ast@fb.com
Subject: Re: [PATCH elfutils 2/2] [tests] parse inode in /proc/pid/maps correctly in run-backtrace-data.sh
Date: Tue, 29 Jan 2019 20:50:00 -0000 [thread overview]
Message-ID: <20190129205012.GK9378@wildebeest.org> (raw)
In-Reply-To: <20190125212009.2775258-3-yhs@fb.com>
On Fri, Jan 25, 2019 at 01:20:09PM -0800, Yonghong Song wrote:
> The backtrace-data.c parsed the inode in /proc/pid/maps with
> format "%*x".
> This caused failure if inode is big. For example,
> 7f269223d000-7f269226b000 r-xp 00000000 00:50 10224326387095067468 /home/...
I have a bit of trouble replicating this (with a simple sscanf).
How exactly does it fail?
> The correct format should be "%*lu" to reflect inode "unsigned long" type.
> But that caused the following compilation error.
> acktrace-data.c: In function âmaps_lookupâ:
> backtrace-data.c:109:22: error: use of assignment suppression and length modifier
> together in gnu_scanf format [-Werror=format=]
> i = fscanf (f, "%lx-%lx %*s %lx %*x:%*x %*lu", &start, &end, &offset);
Not that it matters much, since we are really ignoring the rest of the
line and this is just a test. But I do wonder why %*u doesn't work.
The warning says you cannot combine a length specifier with
a ignored format specifier. Which kind of makes sense given that the
length is for the variable to assign the value for, not the format.
So it seems $*u should do the trick. But since I haven't been able
to make the original fail, I might be wrong.
Cheers,
Mark
next prev parent reply other threads:[~2019-01-29 20:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-25 21:20 [PATCH elfutils 0/2] fix two /proc/pid/maps inode parsing issues Yonghong Song
2019-01-25 21:20 ` [PATCH elfutils 2/2] [tests] parse inode in /proc/pid/maps correctly in run-backtrace-data.sh Yonghong Song
2019-01-29 20:50 ` Mark Wielaard [this message]
2019-01-29 21:23 ` Yonghong Song
2019-01-31 21:14 ` Mark Wielaard
2019-01-31 22:26 ` Mark Wielaard
2019-01-25 21:20 ` [PATCH elfutils 1/2] [libdwfl] parse inode in /proc/pid/maps correctly Yonghong Song
2019-01-29 20:10 ` Mark Wielaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190129205012.GK9378@wildebeest.org \
--to=mark@klomp.org \
--cc=ast@fb.com \
--cc=elfutils-devel@sourceware.org \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).