[PATCH] libelf: Remove unused __elf_xfctstof.

[PATCH] libelf: Remove unused __elf_xfctstof.

[Mark Wielaard]

__elf_xfctstof is only used in case the memory size and file size of ELF
data structures are different. This is never the case.

Signed-off-by: Mark Wielaard <mark@klomp.org>
---
 libelf/ChangeLog    | 5 +++++
 libelf/gelf_xlate.c | 4 ----
 libelf/libelfP.h    | 2 --
 3 files changed, 5 insertions(+), 6 deletions(-)

diff --git a/libelf/ChangeLog b/libelf/ChangeLog
index 28cab9c40..a2e4ee900 100644
--- a/libelf/ChangeLog
+++ b/libelf/ChangeLog
@@ -1,3 +1,8 @@
+2019-02-24  Mark Wielaard  <mark@klomp.org>
+
+	* gelf_xlate.c (__elf_xfctstof): Remove alias.
+	* libelfP.h (__elf_xfctstof): Remove definition.
+
 2019-02-24  Mark Wielaard  <mark@klomp.org>
 
 	* elf32_fsize.c (local_strong_alias): Remove definition.
diff --git a/libelf/gelf_xlate.c b/libelf/gelf_xlate.c
index f6f496d47..b9e7fd655 100644
--- a/libelf/gelf_xlate.c
+++ b/libelf/gelf_xlate.c
@@ -208,7 +208,3 @@ const xfct_t __elf_xfctstom[ELFCLASSNUM - 1][ELF_T_NUM] =
 	[ELF_T_GNUHASH] = elf_cvt_gnuhash
       }
 };
-/* For now we only handle the case where the memory representation is the
-   same as the file representation.  Should this change we have to define
-   separate functions.  For now reuse them.  */
-strong_alias (__elf_xfctstom, __elf_xfctstof)
diff --git a/libelf/libelfP.h b/libelf/libelfP.h
index 3a96a3b01..513441422 100644
--- a/libelf/libelfP.h
+++ b/libelf/libelfP.h
@@ -413,8 +413,6 @@ typedef void (*xfct_t) (void *, const void *, size_t, int);
 /* The table with the function pointers.  */
 extern const xfct_t __elf_xfctstom[ELFCLASSNUM - 1][ELF_T_NUM]
   attribute_hidden;
-extern const xfct_t __elf_xfctstof[ELFCLASSNUM - 1][ELF_T_NUM]
-  attribute_hidden;
 
 
 /* Array with sizes of the external types indexed by ELF version, binary
-- 
2.20.1

Re: [PATCH] libelf: Remove unused __elf_xfctstof.

[Mark Wielaard]

On Sun, Feb 24, 2019 at 06:18:11PM +0100, Mark Wielaard wrote:
> __elf_xfctstof is only used in case the memory size and file size of ELF
> data structures are different. This is never the case.

Pushed to master.