From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 73286 invoked by alias); 11 Jul 2019 03:20:34 -0000 Mailing-List: contact elfutils-devel-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Post: List-Help: List-Subscribe: Sender: elfutils-devel-owner@sourceware.org Received: (qmail 73270 invoked by uid 89); 11 Jul 2019 03:20:34 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.100.3 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-21.6 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,UNPARSEABLE_RELAY autolearn=ham version=3.3.1 spammy= X-Spam-Status: No, score=-21.6 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on sourceware.org X-Spam-Level: X-HELO: smtp2200-217.mail.aliyun.com Received: from smtp2200-217.mail.aliyun.com (HELO smtp2200-217.mail.aliyun.com) (121.197.200.217) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 11 Jul 2019 03:20:33 +0000 X-Alimail-AntiSpam:AC=CONTINUE;BC=0.1497692|-1;CH=green;DM=||false|;FP=0|0|0|0|0|-1|-1|-1;HT=e01l07423;MF=han_mao@c-sky.com;NM=1;PH=DS;RN=2;RT=2;SR=0;TI=SMTPD_---.Evpf57t_1562815230; Received: from localhost(mailfrom:han_mao@c-sky.com fp:SMTPD_---.Evpf57t_1562815230) by smtp.aliyun-inc.com(10.147.40.233); Thu, 11 Jul 2019 11:20:31 +0800 Date: Thu, 11 Jul 2019 03:20:00 -0000 From: Mao Han To: Mark Wielaard Cc: elfutils-devel@sourceware.org Subject: Re: [[RESEND & PING]PATCH V3 1/1] Add backend support for C-SKY Message-ID: <20190711031900.GA943@vmh-VirtualBox> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-IsSubscribed: yes X-SW-Source: 2019-q3/txt/msg00043.txt.bz2 Hi, Mark On Thu, Jul 11, 2019 at 12:11:17AM +0200, Mark Wielaard wrote: > As far as I can see this is like a SHT_GNU_ATTRIBUTES or > SHT_ARM_ATTRIBUTES section. If so, you will also want something like: > > diff --git a/src/readelf.c b/src/readelf.c > index cda7c93..8017dc4 100644 > --- a/src/readelf.c > +++ b/src/readelf.c > @@ -3571,7 +3571,9 @@ print_attributes (Ebl *ebl, const GElf_Ehdr > *ehdr) > > if (shdr == NULL || (shdr->sh_type != SHT_GNU_ATTRIBUTES > && (shdr->sh_type != SHT_ARM_ATTRIBUTES > - || ehdr->e_machine != EM_ARM))) > + || ehdr->e_machine != EM_ARM) > + && (shdr->sh_type != SHT_CSKY_ATTRIBUTES > + || ehdr->e_machine != EM_CSKY))) > continue; > > printf (gettext ("\ > > And then hook check_object_attribute to display any CSKY specific > attribute names/values. Ok, I'll add check for C-SKY here. Thanks, Mao Han