From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 60900 invoked by alias); 19 Jul 2019 21:23:13 -0000 Mailing-List: contact elfutils-devel-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Post: List-Help: List-Subscribe: Sender: elfutils-devel-owner@sourceware.org Received: (qmail 60890 invoked by uid 89); 19 Jul 2019 21:23:13 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.100.3 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-7.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy= X-Spam-Status: No, score=-7.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on sourceware.org X-Spam-Level: X-HELO: vmicros1.altlinux.org Received: from vmicros1.altlinux.org (HELO vmicros1.altlinux.org) (194.107.17.57) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 19 Jul 2019 21:23:11 +0000 Received: from mua.local.altlinux.org (mua.local.altlinux.org [192.168.1.14]) by vmicros1.altlinux.org (Postfix) with ESMTP id CF23D72CA65; Sat, 20 Jul 2019 00:23:08 +0300 (MSK) Received: by mua.local.altlinux.org (Postfix, from userid 508) id B547F7CC774; Sat, 20 Jul 2019 00:23:08 +0300 (MSK) Date: Fri, 19 Jul 2019 21:23:00 -0000 From: "Dmitry V. Levin" To: Florian Weimer Cc: Mark Wielaard , elfutils-devel@sourceware.org, Panu Matilainen Subject: Re: [PATCH] elfclassify tool Message-ID: <20190719212308.GA31813@altlinux.org> References: <87k1fz8c9q.fsf@oldenburg2.str.redhat.com> <2e6a27c552ae5e365db54ca6b432c77c9ad5b041.camel@klomp.org> <871s22yybt.fsf@oldenburg2.str.redhat.com> <8736mfzhob.fsf@oldenburg2.str.redhat.com> <20190719134341.GA26346@altlinux.org> <84da918d32c57e6f16fbcf1c854b375111dbdcb5.camel@wildebeest.org> <20190719183542.GB29323@altlinux.org> <87v9vxivsu.fsf@oldenburg2.str.redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="jI8keyz6grp/JLjh" Content-Disposition: inline In-Reply-To: <87v9vxivsu.fsf@oldenburg2.str.redhat.com> X-IsSubscribed: yes X-SW-Source: 2019-q3/txt/msg00068.txt.bz2 --jI8keyz6grp/JLjh Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-length: 749 On Fri, Jul 19, 2019 at 11:00:49PM +0200, Florian Weimer wrote: > * Dmitry V. Levin: >=20 > >> So, I don't think the code is wrong. We might want to tweak the comment > >> a bit though, to make it less definitive? > > > > What I'm saying is that has_soname is just a hint which is probably even > > less reliable than has_program_interpreter. >=20 > If I recall correctly, I added the soname check to classify > /lib64/libc.so.6 as a library, not an executable. So it didn't come > completely out of nowhere. Well, /lib64/libc.so.6 is not just a library, it's also a valid executable. If the ELF type is ET_DYN and the object is not marked as DF_1_PIE, could we come up with a more reliable heuristics than DT_SONAME and PT_INTE= RP? --=20 ldv --jI8keyz6grp/JLjh Content-Type: application/pgp-signature; name="signature.asc" Content-length: 801 -----BEGIN PGP SIGNATURE----- iQIcBAEBCAAGBQJdMjS8AAoJEAVFT+BVnCUIxBcQAO3OwsgP8gpHuHYCv7ChAgs6 NYcqEIMB5mVqCH8yPpan7cF81BzvmkDm6eA5ChFtzf0VZGbty+aE0/KtGbcQNNDU vggkKntXoT0K3QIU2B4QkmTj/JoptV8ovNjW/hxO+3W88Ipjeb72N1Qi7rHz/onj 6h1rcgS7GEFA6SQjhf2ZEGX6sv4CLfXuzqjgHrrurKT6xbWomSTrT57dTZ0niT2r 04VQBkDqHBaECXG3mUKajxyGCpll4d4PJBH1vqawYlYfadUjQvK6WN0gbKUTOmss KyEpADlY0G1rexsashB6po88/+5x6bVBhvNaOxksoQIkra6cUFbbbsvUINBHV9eI jvyg/9T2fEA463vfz5QOuN8whDt5VD3fKRTDvCLzm0QLTPJaCxlKzWrDH0k/exIC D6LuSy70PoKWx65QpBbnKSrMGnLa2UENwuKQkdUG36F4NkL/JcSy1b1SZC8/oAZ8 DdD4qbRGSAHyH0po/fB+J9ksT8ql3PY1LqG2N4j+5d4VAeCPP2IewoP0qulzHsmM MNpVB0cOid7xIImGqlDgQw6mL4JQo83tRqKHcFtzvJTQTK4nJC05GiyDx74DLPiv Jq2jfCbKZCXzvva+iI1rD0AxdLV9I6qSz4umRGPs6iRpGG2zo8pV2dLvMQqtVTt1 fTEtjnAQUkBNoL2EhU2K =mhm/ -----END PGP SIGNATURE----- --jI8keyz6grp/JLjh--