On Sat, Jul 20, 2019 at 11:51:16PM +0200, Mark Wielaard wrote:
> On Sat, Jul 20, 2019 at 01:57:27AM +0300, Dmitry V. Levin wrote:
[...]
> > btw, I think it would be appropriate to move the has_dynamic check before
> > the first check in is_shared that returns true.
> 
> Yes, that is probably fine, but does it really matter?

It doesn't matter unless the file has DT_SONAME but doesn't have PT_DYNAMIC.

If /lib64/ld-linux-x86-64.so.2 --verify doesn't like files without
PT_DYNAMIC, elfclassify --shared shouldn't classify them as DSOs, too.


-- 
ldv