From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18366 invoked by alias); 26 Jul 2019 23:04:52 -0000 Mailing-List: contact elfutils-devel-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Post: List-Help: List-Subscribe: Sender: elfutils-devel-owner@sourceware.org Received: (qmail 18356 invoked by uid 89); 26 Jul 2019 23:04:51 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.100.3 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-7.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy=dmitry, Dmitry, Sat X-Spam-Status: No, score=-7.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on sourceware.org X-Spam-Level: X-HELO: vmicros1.altlinux.org Received: from vmicros1.altlinux.org (HELO vmicros1.altlinux.org) (194.107.17.57) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 26 Jul 2019 23:04:50 +0000 Received: from mua.local.altlinux.org (mua.local.altlinux.org [192.168.1.14]) by vmicros1.altlinux.org (Postfix) with ESMTP id C3E8C72CC6C; Sat, 27 Jul 2019 02:04:48 +0300 (MSK) Received: by mua.local.altlinux.org (Postfix, from userid 508) id 992447CCE4F; Sat, 27 Jul 2019 02:04:48 +0300 (MSK) Date: Fri, 26 Jul 2019 23:04:00 -0000 From: "Dmitry V. Levin" To: Mark Wielaard Cc: Florian Weimer , elfutils-devel@sourceware.org, Panu Matilainen Subject: Re: [PATCH] elfclassify tool Message-ID: <20190726230448.GB14246@altlinux.org> References: <8736mfzhob.fsf@oldenburg2.str.redhat.com> <20190719134341.GA26346@altlinux.org> <84da918d32c57e6f16fbcf1c854b375111dbdcb5.camel@wildebeest.org> <20190719183542.GB29323@altlinux.org> <87v9vxivsu.fsf@oldenburg2.str.redhat.com> <20190719212308.GA31813@altlinux.org> <20190719213653.GA2851@wildebeest.org> <20190719225727.GA31985@altlinux.org> <20190720215116.GC2851@wildebeest.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="R3G7APHDIzY6R/pk" Content-Disposition: inline In-Reply-To: <20190720215116.GC2851@wildebeest.org> X-IsSubscribed: yes X-SW-Source: 2019-q3/txt/msg00081.txt.bz2 --R3G7APHDIzY6R/pk Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-length: 559 On Sat, Jul 20, 2019 at 11:51:16PM +0200, Mark Wielaard wrote: > On Sat, Jul 20, 2019 at 01:57:27AM +0300, Dmitry V. Levin wrote: [...] > > btw, I think it would be appropriate to move the has_dynamic check befo= re > > the first check in is_shared that returns true. >=20 > Yes, that is probably fine, but does it really matter? It doesn't matter unless the file has DT_SONAME but doesn't have PT_DYNAMIC. If /lib64/ld-linux-x86-64.so.2 --verify doesn't like files without PT_DYNAMIC, elfclassify --shared shouldn't classify them as DSOs, too. --=20 ldv --R3G7APHDIzY6R/pk Content-Type: application/pgp-signature; name="signature.asc" Content-length: 801 -----BEGIN PGP SIGNATURE----- iQIcBAEBCAAGBQJdO4cQAAoJEAVFT+BVnCUIjXgQAJ7GciO7+uuM+4rx7SskSSP5 W7YswEV/rmLcTnMpjoyBLYdkf0QucQEWXY2Gu8TlaOwDEwjFRbX36BA5nbmj/YKg ilFFyQQNBwB30GtPGF7gGCb6yE9nI/87A+YEhhqImW6rGj6W8UsyK54vo4Y9LVbN BXbxXweVHRL9MKagsyUhwZSEVgMuuTsqIIGoZ9W+6cwXZj87fbWvjo40PCwRMqcr RRDCDYfgmvAjXl1LNSTo7EomCZRVESX3a77Yq+seUis9MUQ/IqBXd+Y9q7WCoCOE jQsNLRWq1gPM0yVC1WUFQATWEpZdI9JiK6yoz44+N1DOQVy3HTVapgHc/gtsPthN gNiurR3zcTeMWRaIyxDA5XAbiuu3wVC8DEmFL71MNhFqtknhz2qQdhci3/vmUMSg d1QbmH2JZ/6Lcjtsuqf9kJwUARHsBs/CoGtINB/KipknhNSsIOUTBTwzuFwrxGRU WK3pDIF3EpDIMkxog99YWxSF5vr4uAKg4Oa9lcply+rwNQWHG2TwryUOJmghgQu2 yag58CZBpVTHDrzBWQwMlF7kEUQcdGYmbw2DLfuVZWfJcJUrgOs7y+XShSboOtDE WCBoLCr+dr02ls9sG+3vtdy9atyJwx7fq45l4ahnrCAenFM3xJYH4UxnLpTaHMqT 800UyGlazpOpu0FzZfyv =2dWo -----END PGP SIGNATURE----- --R3G7APHDIzY6R/pk--