From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 33272 invoked by alias); 29 Jul 2019 14:40:28 -0000 Mailing-List: contact elfutils-devel-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Post: List-Help: List-Subscribe: Sender: elfutils-devel-owner@sourceware.org Received: (qmail 33224 invoked by uid 89); 29 Jul 2019 14:40:28 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.100.3 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-10.0 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.1 spammy=Origin, Certificate, commits X-Spam-Status: No, score=-10.0 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on sourceware.org X-Spam-Level: X-HELO: gnu.wildebeest.org Received: from wildebeest.demon.nl (HELO gnu.wildebeest.org) (212.238.236.112) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 29 Jul 2019 14:40:26 +0000 Received: from librem.wildebeest.org (host81-133-75-206.in-addr.btopenworld.com [81.133.75.206]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id 1906E308B2F5; Mon, 29 Jul 2019 16:40:23 +0200 (CEST) Received: by librem.wildebeest.org (Postfix, from userid 1000) id 9C244C01C0; Mon, 29 Jul 2019 16:40:21 +0200 (CEST) Date: Mon, 29 Jul 2019 14:40:00 -0000 From: Mark Wielaard To: Florian Weimer Cc: elfutils-devel@sourceware.org, Panu Matilainen Subject: Re: [PATCH] elfclassify tool Message-ID: <20190729144021.GD2881@wildebeest.org> References: <87k1fz8c9q.fsf@oldenburg2.str.redhat.com> <2e6a27c552ae5e365db54ca6b432c77c9ad5b041.camel@klomp.org> <871s22yybt.fsf@oldenburg2.str.redhat.com> <8736mfzhob.fsf@oldenburg2.str.redhat.com> <87k1cadpym.fsf@oldenburg2.str.redhat.com> <20190726221124.GA39429@wildebeest.org> <875znl6vqy.fsf@oldenburg2.str.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <875znl6vqy.fsf@oldenburg2.str.redhat.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Spam-Flag: NO X-IsSubscribed: yes X-SW-Source: 2019-q3/txt/msg00093.txt.bz2 On Mon, Jul 29, 2019 at 11:22:13AM +0200, Florian Weimer wrote: > * Mark Wielaard: > > > Signed-off-by: Mark Wielaard > > Does elfutils use DCO? Then yoy have my signoff as well: > > Signed-off-by: Florian Weimer Thanks. Yes, elfutils uses a Developer Certificate of Origin based on the linux kernel one (but clarified for the elfutils project details - like some files having multiple licenses at the same time). We do require all commits to have a Signed-off-by line from developers that agree with the DCO as explained in the CONTRIBUTING document. > You should you list yourself as an author somewhere in the commit > message. The ChangeLog entries do mention both of us as authors. > Regarding the test case, I think if the build target is ELF, it makes > sense to check that the elfutils binaries themselves are classified as > expected, with the current build flags. This will detect changes > required due to the evolution of the toolchain. That is what the run-elfclassify-self.sh testcase does I believe. Or do you believe it should be extended? Thanks, Mark