From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 56904 invoked by alias); 12 Aug 2019 15:18:54 -0000 Mailing-List: contact elfutils-devel-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Post: List-Help: List-Subscribe: Sender: elfutils-devel-owner@sourceware.org Received: (qmail 56890 invoked by uid 89); 12 Aug 2019 15:18:54 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.100.3 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.4 required=5.0 tests=BAYES_00,RCVD_IN_SORBS_WEB,SPF_PASS autolearn=no version=3.3.1 spammy=objections, selling X-Spam-Status: No, score=-0.4 required=5.0 tests=BAYES_00,RCVD_IN_SORBS_WEB,SPF_PASS autolearn=no version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on sourceware.org X-Spam-Level: X-HELO: gnu.wildebeest.org Received: from wildebeest.demon.nl (HELO gnu.wildebeest.org) (212.238.236.112) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 12 Aug 2019 15:18:52 +0000 Received: from librem.wildebeest.org (unknown [87.195.226.149]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id 894BF30012F6; Mon, 12 Aug 2019 17:18:50 +0200 (CEST) Received: by librem.wildebeest.org (Postfix, from userid 1000) id B0E32C01CD; Mon, 12 Aug 2019 17:18:44 +0200 (CEST) Date: Mon, 12 Aug 2019 15:18:00 -0000 From: Mark Wielaard To: Florian Weimer Cc: elfutils-devel@sourceware.org, Panu Matilainen Subject: Re: [PATCH] elfclassify tool Message-ID: <20190812151844.GA2824@wildebeest.org> References: <2e6a27c552ae5e365db54ca6b432c77c9ad5b041.camel@klomp.org> <871s22yybt.fsf@oldenburg2.str.redhat.com> <8736mfzhob.fsf@oldenburg2.str.redhat.com> <87k1cadpym.fsf@oldenburg2.str.redhat.com> <20190726221124.GA39429@wildebeest.org> <87ef296xir.fsf@oldenburg2.str.redhat.com> <20190729142419.GB2881@wildebeest.org> <87a7cex0kj.fsf@oldenburg2.str.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87a7cex0kj.fsf@oldenburg2.str.redhat.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Spam-Flag: NO X-IsSubscribed: yes X-SW-Source: 2019-q3/txt/msg00105.txt.bz2 On Mon, Aug 12, 2019 at 10:14:20AM +0200, Florian Weimer wrote: > * Mark Wielaard: > > > What do you think about this change to dwelf_elf_begin? > > The change would make it possible to detect real errors in the > > elfclassify code, whether elf_begin or dwelf_elf_begin was used. So we > > would not misclassify files (but return an error status of 2). > > I'm not really familiar with how these functions are used, sorry, I think you are selling yourself short. You did spot the issue with using them. And that using them as "advertised" could cause problems. Thanks for that. > Viewed in isolation, the changes appear reasonable to me. Thanks. That certainly is helpful feedback. Unless there are objections or questions from other I intend to check this into master tomorrow. Cheers, Mark