From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25629 invoked by alias); 13 Aug 2019 09:44:39 -0000 Mailing-List: contact elfutils-devel-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Post: List-Help: List-Subscribe: Sender: elfutils-devel-owner@sourceware.org Received: (qmail 25508 invoked by uid 89); 13 Aug 2019 09:44:32 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Checked: by ClamAV 0.100.3 on sourceware.org X-Virus-Found: No X-Spam-SWARE-Status: No, score=-12.9 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_SORBS_WEB,SPF_PASS autolearn=ham version=3.3.1 spammy= X-Spam-Status: No, score=-12.9 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_SORBS_WEB,SPF_PASS autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on sourceware.org X-Spam-Level: X-HELO: gnu.wildebeest.org Received: from wildebeest.demon.nl (HELO gnu.wildebeest.org) (212.238.236.112) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 13 Aug 2019 09:44:31 +0000 Received: from librem.wildebeest.org (unknown [87.195.226.149]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id 1001230012EA; Tue, 13 Aug 2019 11:44:28 +0200 (CEST) Received: by librem.wildebeest.org (Postfix, from userid 1000) id 7B526C019C; Tue, 13 Aug 2019 11:44:28 +0200 (CEST) Date: Tue, 13 Aug 2019 09:44:00 -0000 From: Mark Wielaard To: Florian Weimer Cc: elfutils-devel@sourceware.org, Panu Matilainen Subject: Re: [PATCH] elfclassify tool Message-ID: <20190813094428.GA2467@wildebeest.org> References: <87k1fz8c9q.fsf@oldenburg2.str.redhat.com> <2e6a27c552ae5e365db54ca6b432c77c9ad5b041.camel@klomp.org> <871s22yybt.fsf@oldenburg2.str.redhat.com> <8736mfzhob.fsf@oldenburg2.str.redhat.com> <87k1cadpym.fsf@oldenburg2.str.redhat.com> <20190726221124.GA39429@wildebeest.org> <87a7cx6w0g.fsf@oldenburg2.str.redhat.com> <20190729143441.GC2881@wildebeest.org> <87pnls29eu.fsf@oldenburg2.str.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87pnls29eu.fsf@oldenburg2.str.redhat.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Spam-Flag: NO X-IsSubscribed: yes X-SW-Source: 2019-q3/txt/msg00106.txt.bz2 On Mon, Jul 29, 2019 at 04:38:17PM +0200, Florian Weimer wrote: > > On Mon, Jul 29, 2019 at 11:16:31AM +0200, Florian Weimer wrote: > > So the test should be: > > > > diff --git a/src/elfclassify.c b/src/elfclassify.c > > index ebd42c1d5..b17d14d45 100644 > > --- a/src/elfclassify.c > > +++ b/src/elfclassify.c > > @@ -862,7 +862,7 @@ process_stdin (int *status) > > break; > > if (ret < 0) > > abort (); /* Cannot happen due to error checks above. */ > > - if (delim != '\0' && ret > 0) > > + if (delim != '\0' && ret > 0 && buffer[ret - 1] == '\n') > > buffer[ret - 1] = '\0'; > > current_path = buffer; > > process_current_path (status); > > Right. But now I wonder why ret == 0 can ever happen. Maybe on > OpenVMS, which doesn't use in-band signaling for line terminators? I also couldn't create a situation where ret == 0. But I still included the change because it feels more robust. Thanks, Mark